Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR resolves the duplicate
/api/healthhandler conflict by consolidating health configuration into a single shared module and ensuring bothcreateAppand thesrc/index.tsentrypoint serve the same enveloped response shape from the same source of truth.Related Issue
Changes
🩺 Health Handler Consolidation
[ADD]
src/config/health.tscreateAppand the index app.[MODIFY]
src/app.tsapp.get('/api/health')handler with the shared health configuration so the response shape and headers come fromsrc/config/health.ts.[MODIFY]
src/index.ts/api/healthhandler returning an unenveloped body and routes through the shared health configuration instead.Verification Results
Both entrypoints now return the same enveloped shape and headers for
GET /api/health, and the redundant handler has been removed so exactly one implementation remains.createAppand index app sharesrc/config/health.tsSecurity and Failure-Mode Handling
Compatibility Considerations
/api/healthare unaffected.src/routes/health.tsnow take effect as expected since the duplicate handler is gone.Closes #1319