test(fee): add recipient validation tests and error stability checks - #1339
Open
Osuochasam wants to merge 1 commit into
Open
Osuochasam wants to merge 1 commit into
Osuochasam wants to merge 1 commit into
Conversation
|
@Osuochasam Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR introduces explicit test coverage for the validate_recipient logic within the fee contract. It ensures that withdrawal transactions sent to the contract itself or to the hardcoded ZERO_CONTRACT_ADDRESS correctly fail with an InvalidRecipient error. Most importantly, it proves that the hardcoded zero address parses safely via Address::from_str without trapping, which would otherwise brick fee payouts. It also locks in the associated error code to prevent undocumented API breaks.
Key Changes
Recipient Validation Tests (contracts/fee/...):
Added a test verifying that attempting to withdraw to the contract's own address correctly returns InvalidRecipient.
Added a test verifying that withdraw to ZERO_CONTRACT_ADDRESS returns InvalidRecipient, effectively proving the constant parses successfully.
Added a success case test verifying that withdrawals to a standard, valid address process correctly.
Error Code Stability (contracts/fee/tests/err_stab.rs):
Appended InvalidRecipient = 8 to the error stability assertions to ensure the error code does not silently drift in future refactors.
closes #1191