Skip to content

Delete orphaned root-level ApiUsage duplicate #1187

Description

@greatest0fallt1me

Summary

src/ApiUsage.tsx (717 lines) and its test duplicate src/pages/ApiUsage.tsx (861 lines); App lazy-loads only the pages version. Similar duplicates exist for ThemeToggle, CallHistoryRow, FiltersSidebar and PlanBadge across src/, components/ and pages/.

Why this matters

Contributors fix bugs in the wrong copy, and tests of dead code inflate coverage while the live page stays untested.

Scope

Remove src/ApiUsage.tsx and src/ApiUsage.test.tsx after porting any unique tests, and open follow-ups for the other duplicate pairs with a table of which copy is live.

Relevant code in CalloraOrg/Callora-Frontend:

  • src/ApiUsage.tsx
  • src/ApiUsage.test.tsx
  • src/pages/ApiUsage.tsx
  • src/ThemeToggle.tsx
  • src/pages/ThemeToggle.tsx

Priority

Low

Acceptance criteria

  • src/ApiUsage.tsx is removed
  • Unique assertions are ported to pages tests
  • No import references the removed file
  • Duplicate pairs are listed for follow-up

Validation

npm run build && npm test -- --run src/pages/ApiUsage.test.tsx

Non-goals

  • Typo-only, formatting-only, or cosmetic changes.
  • Unrelated refactors, dependency upgrades, or broad rewrites.
  • Removing safeguards or weakening validation to make tests pass.

Contributor application

Before coding, describe the affected modules, proposed state/invariant changes, test strategy, compatibility considerations, and an estimate. Wait for assignment before starting implementation.

PR requirements

Use a feature branch and include Closes #<issue-number>. Address every criterion, map criteria to code and tests, explain security and failure-mode handling, and ensure CI passes.

Quality review

A maintainer will assess correctness, completeness, test depth, compatibility, observability, and adverse-case handling. A substantive implementation is required; merge or CI status alone does not guarantee reward eligibility.


Generated by Claude Code

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Stellar WaveStellar Wave Program issue

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions