Clarify logout and invite voluntary Open Food Facts contributions - #129
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes are limited to UI copy and a safe external link (with appropriate target/rel), with no alterations to authentication/logout logic.
Pull request overview
This PR refines logout copy in the account panel to avoid overstating device/session scope, and adds a low-friction, optional link encouraging voluntary contributions to Open Food Facts while preserving existing attribution.
Changes:
- Updates embedded-session helper text and standardizes the logout button label/state to “Log out” / “Logging out...”.
- Adds a short thank-you message plus an external “Contribute to Open Food Facts” link (opens in a new tab) in the home page footer.
File summaries
| File | Description |
|---|---|
| frontend/components/XamanLoginPanel.tsx | Clarifies embedded logout messaging and simplifies the logout button labels. |
| frontend/app/page.tsx | Adds an optional Open Food Facts contribution link and supporting footer copy. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The account panel describes the joint session button as “Sign out everywhere”, which is unclear and overstates its device scope. The app already credits Open Food Facts but offers no way for a grateful user to contribute.
This PR uses “Log out” / “Logging out...” and explains that embedded logout ends the CalorieToken.net and CalorieApp sessions on this device. It adds a quiet thank-you and optional contribution link at the bottom inside CalorieApp, preserving the existing Open Food Facts attribution and ODbL link.
The contribution link opens the official Open Food Facts contributor page in a new tab. No form submission or donation is initiated.
The account controller diff contains presentation strings only;
handleLogout, authentication, storage and bridge messaging are unchanged. Based directly on accepted mainf689a4acd9bb34f49c6f06267fb22537b17495b0. WordPress widget positioning and floating shortcuts are prepared separately in #130.Validation: exact comparison confirms the account controller differs only in the requested strings. The existing copy assertion was updated from “Sign out everywhere” to the device-scoped explanation. All CI jobs pass on final head
9cf5d57a49d011bbd17622dbb4dff0cb09ac8d51, including frontend lint, build and authentication tests, backend tests, repository boundary and plugin release check. Copilot reviewed 3/3 changed files on that head with zero new comments; its formal review state is COMMENTED with approval recommended. Native rendered review was completed after the approved deployment on 2026-09-07.Merged and deployed with the user's approval on 2026-09-07.
Deployment verification: merge
4baea3acaeaa14dacc602ae8d6154ab4c7e97836preserves the reviewed treecf6116569be39336a8d98ac06491e9140e826bea. Render reported Deploy succeeded | Live for this exact commit after a manual deployment (1m06s); automatic deployment remains disabled. The thank-you text, existing OFF/ODbL attribution and optional contribution link were verified inside the live WordPress iframe at https://calorietoken.net/index.php/calorieapp/. The link uses_blankwithnoopener noreferrer.Visual checks covered the live desktop viewport (1363 × 936) and the native WordPress Customizer mobile preview (320px wide). The footer and contribution link fit and wrap on mobile. The signed-in app label was validated through the reviewed source and CI; this visual check used an anonymous app session and did not initiate another wallet sign-in or live logout.