Skip to content

Keep the Xumm widget inside narrow desktop columns - #131

Open
xrpbanks wants to merge 3 commits into
fix/bridge-033-status-refreshfrom
fix/desktop-widget-column-fit
Open

Keep the Xumm widget inside narrow desktop columns#131
xrpbanks wants to merge 3 commits into
fix/bridge-033-status-refreshfrom
fix/desktop-widget-column-fit

Conversation

@xrpbanks

@xrpbanks xrpbanks commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

The 220px Xumm account card extends about 15px beyond the visible page edge in the native 1063px desktop preview. Its Brizy column is narrower than the card, while the shortcode retains a 34% width limit.

Plugin 0.3.23 lets the desktop shortcode use its column and centres the card at up to 220px, shrinking it when the column is narrower. Only horizontal margins change; vertical spacing stays theme-controlled. The new rules apply from 769px. Mobile CSS, all JavaScript files, and authentication/session logic remain unchanged. Release metadata advances the two plugin version declarations and the single fallback asset-version string in register_assets(); the README describes the change.

Based on accepted maintenance merge df216a14218303cec0907c1b0f8fd8310f0aa343, targeting fix/bridge-033-status-refresh. Final source: a00dbf92f6022603243c9ab44ca7c68af7412d05, tree 24b35e8e1b765c0abd424c443f36c7a50ea48c37. Exactly four files differ; the only change under includes/ is the fallback version string.

Validation completed:

  • Bridge maintenance checks passed on this exact head, run 34093741474: PHP lint/rendering, 15 existing JavaScript tests, eight release-builder tests, and deterministic package construction.
  • Copilot reviewed all four final files with zero new comments. Its review is COMMENTED / Needs a closer look, requesting final manual WordPress/Brizy checks. All three earlier review threads are resolved.
  • The local snapshot was synchronized to the final head; all 41 present tracked files match the final Git tree.
  • The existing maintenance release builder produced the 0.3.23 ZIP, 52,484 bytes. Every one of its 22 members matches the corresponding final Git blob. ZIP, checksum, and manifest have been saved for the user. SHA-256: 9de31f11c56ffd2ac0c2bb8e579e06e8e201bc0d25afae726368186dab2f980d. This uses the existing local build/test route; distribution-clearance metadata remains unchanged.

The earlier native desktop preview showed the original card at x=842.67–1062.67 within 1048px of visible content. Candidate CSS moved it to x=837.67–1032.98, leaving 15.02px inside the right edge, with height unchanged at 164.875px. The subsequent review adjustment preserves the theme's existing 5px vertical margins. That exact final adjustment still needs rendered confirmation, followed by wide-desktop and mobile checks.

The temporary Additional CSS preview has not been published. The resumed browser initially exposed the unsaved preview, but timed out during Cancel; discarding it could not be confirmed. Subsequent tab interactions also timed out. On recovery, discard the old unpublished preview first. Because 0.3.23 is now installed, inspect the ordinary live pages using the installed stylesheet; do not add another copy of the candidate CSS.

The user reports manually installing plugin 0.3.23 on 7 September 2026. This records the user's installation confirmation; the installed version and final layout have not yet been independently verified in the WordPress UI. The user will provide desktop screenshots. Final visual checks and explicit merge approval remain pending. This PR is still unmerged; the app deployment is unchanged.

@xrpbanks
xrpbanks marked this pull request as ready for review September 7, 2026 06:49
Copilot AI lite review requested due to automatic review settings September 7, 2026 06:49

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The new desktop CSS uses a forced margin: 5px auto !important which can unintentionally override theme vertical spacing and impact header layout, and the README update needs minor clarity/wrapping fixes.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR updates the CalorieApp Identity Bridge WordPress plugin to v0.3.23 to prevent the Xumm account card from overflowing/clipping in narrow desktop Brizy columns by making the shortcode wrapper use full column width and centering the card up to 220px from 769px and up.

Changes:

  • Bump plugin version declarations from 0.3.22 to 0.3.23.
  • Add desktop-only CSS (≥769px) to force the Brizy shortcode container to use the full column width and to constrain/center the identity card to max 220px.
  • Document the v0.3.23 layout change in the plugin README.
File summaries
File Description
wordpress-plugins/calorieapp-identity-bridge/assets/calorieapp-site-layout.css Adds desktop media-query rules to keep the account card within its Brizy column and centered up to 220px.
wordpress-plugins/calorieapp-identity-bridge/calorieapp-identity-bridge.php Updates plugin header/version constant to 0.3.23 (also updates asset versioning for cache busting).
wordpress-plugins/calorieapp-identity-bridge/README.md Adds v0.3.23 release notes describing the desktop card/shortcode width behavior.
Review details
  • Files reviewed: 3/3 changed files
  • Comments generated: 2
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread wordpress-plugins/calorieapp-identity-bridge/README.md Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The version bump to 0.3.23 leaves a remaining hard-coded 0.3.22 fallback version elsewhere, which can lead to inconsistent asset versioning and should be updated for release correctness.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details
  • Files reviewed: 3/3 changed files
  • Comments generated: 1
  • Review effort level: Lite

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The core change is UI/CSS behavior that should be validated with final manual visual checks in WordPress/Brizy at the target breakpoints before approving.

Review details
  • Files reviewed: 4/4 changed files
  • Comments generated: 0 new
  • Review effort level: Lite

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants