fixes TCS dome lamp control - #469
Merged
Merged
Conversation
previously each target set all calib hardware this now stores published tcs, calib, and power telemetry, used to check states before setting. resolves issue 467
and request_snapshot can work for a single daemon
prkrtg
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #467
The TCS lamp mechanism takes time to engage and the TCS host only checks for the
NPScommand once per second, so an empirically determined delay of 2s is built in to theNPScommand.This delay would add 8s to setting the dome lamps in the calib_set stage so update calib_set to update only the hardware that needs to be changed. This required some fixes to certain pub-sub areas.