Fixed issue with placeholder val of 1.0e18 - #44
Conversation
weatherhead99
left a comment
There was a problem hiding this comment.
I just checked this and it appear to work.
But I'm not sure about the functioning - it should be allowed to have two differently named floating point constnats with the same value and not have them ambiguous. For example, what if I want both science parallel and science serial high to be +11.0. I do not want science serial subbed into every place where I meant science paarallel.
I just tested that case and it doesn't appear to fail, though. So I'm approving this out of necessity of using it immediately. Thanks!
|
Not all constants were being generated properly in STATES, I think this was due to the placeholder base value -1.0e18 was outside the range where 64-bit floats can represent integer offsets exactly
Seemed to cause a bug where all rounded to the identical float value, so every new constant silently overwrote the previous one's entry in the reverse-lookup dict. Only the last one registered survived and got printed everywhere it is used