Skip to content

fix(recording): write segment start times off the async runtime - #2649

Merged
richiemcilroy merged 1 commit into
mainfrom
fix/start-times-off-runtime
Oct 16, 2026
Merged

richiemcilroy merged 1 commit into
mainfrom
fix/start-times-off-runtime

Conversation

@richiemcilroy

@richiemcilroy richiemcilroy commented Oct 16, 2026 •

Copy link
Copy Markdown
Member

#2642 persists each Studio segment's track start times while recording. The persister ran the write, a file fsync and a directory fsync inside its tokio task, which blocks one runtime worker for the duration of the syncs. The capture pipelines run on the same runtime.

let dir = segment_dir.clone();
let result = tokio::task::spawn_blocking(move || write_segment_start_times(&dir, &times))
    .await
    .unwrap_or_else(|error| Err(std::io::Error::other(error)));
  • crates/recording/src/studio_recording.rs: the write runs on a blocking thread; retries, the 5-attempt limit and the written-state check are unchanged.
  • The persister writes once per track's first frame, so this affects only the first moments of a recording.

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge.

Summary

Moves segment start-time writes and file syncs onto a blocking thread.

  • Segment start-time writes no longer occupy capture runtime workers.

Reviews (1) · Last reviewed commit: "fix(recording): write segment start time..." · Reviewed by Greptile

The start-time persister wrote the file and ran two fsyncs inside its
tokio task, blocking a runtime worker that capture pipelines also use.
The write now runs on a blocking thread.
@vercel

vercel Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
cap-status Ready Ready Preview Oct 16, 2026 2:19pm UTC

@capy-ai capy-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capy found no issues.

Open in Capy

@richiemcilroy
richiemcilroy merged commit c1825e8 into main Oct 16, 2026
52 checks passed

This branch was successfully deployed

2 active deployments
Preview – cap-web — 6c9384ca Deployed Oct 16, 2026 by vercel[bot]
Preview – cap-status — 6c9384ca Deployed Oct 16, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant