Repository navigation
fix(recording): write segment start times off the async runtime - #2649
Merged
Merged
Conversation
The start-time persister wrote the file and ran two fsyncs inside its tokio task, blocking a runtime worker that capture pipelines also use. The write now runs on a blocking thread.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2642 persists each Studio segment's track start times while recording. The persister ran the write, a file
fsyncand a directoryfsyncinside its tokio task, which blocks one runtime worker for the duration of the syncs. The capture pipelines run on the same runtime.crates/recording/src/studio_recording.rs: the write runs on a blocking thread; retries, the 5-attempt limit and the written-state check are unchanged.

Confidence Score: 5/5
The PR appears safe to merge.Summary
Moves segment start-time writes and file syncs onto a blocking thread.
Reviews (1) · Last reviewed commit: "fix(recording): write segment start time..." · Reviewed by Greptile