Skip to content

fix(recording): write segment start times off the async runtime #2649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
richiemcilroy merged 1 commit into from
Oct 16, 2026
Merged

fix(recording): write segment start times off the async runtime #2649

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion crates/recording/src/studio_recording.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1496,7 +1496,15 @@ impl Pipeline {
firsts[3],
);
if written != Some(times) {
match write_segment_start_times(&segment_dir, &times) {
// A blocking write and two fsyncs: keep them off the
// runtime workers the capture pipelines run on.
let dir = segment_dir.clone();
let result = tokio::task::spawn_blocking(move || {
write_segment_start_times(&dir, &times)
})
.await
.unwrap_or_else(|error| Err(std::io::Error::other(error)));
match result {
Ok(()) => written = Some(times),
Err(error) => {
failed_writes += 1;
Expand Down
Loading