Repository navigation
perf(rendering): combine caption active and fade lookup - #2537
KrishCodesw wants to merge 5 commits into
Conversation
|
@KrishCodesw is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
|
Thanks for the PR. Greptile currently has this at 4/5, and we only merge PRs once Greptile scores the current head 5/5. Please address the remaining Greptile feedback, then comment |
|
@greptileai Please re-review the current PR head and update the score. The redundant test comment is absent from the current source, and the Rust formatting changes are committed in |
|
@richiemcilroy Thanks! Greptile now scores the latest PR head 5/5. I've addressed the review feedback. Let me know if anything else is needed. |
|
Hey @richiemcilroy , just wanted to follow up on this PR and check if there are any updates. |
Summary
Closes #2523.
Benchmark
The benchmark is included but has not been run in this environment: Rust/Cargo is not installed, and the container cannot reach GitHub to clone the repository. I have not recorded or claimed a performance gain.
Run from the repository root:
cargo test -p cap-rendering benchmark_caption_lookup_before_and_after --release -- --ignored --nocaptureThe output compares median lookup time for the original two-pass implementation and the new implementation across 2,400 caption segments. Please keep this PR as a draft until the results confirm a useful gain and no unacceptable regression for active-caption lookups.
Validation

Confidence Score: 5/5
No blocking code issues remain; keep the PR draft until the benchmark meets the author's stated release condition.Summary
Combines active-caption and fade lookup into one pass while preserving selection order.
Reviews (2) · Last reviewed commit: "style(rendering): apply rustfmt to capti..." · Reviewed by Greptile