Skip to content

fix(project): normalize Windows recording asset paths - #2610

Merged
richiemcilroy merged 2 commits into
CapSoftware:mainfrom
yashranaway:fix/project-cli
Oct 18, 2026
Merged

richiemcilroy merged 2 commits into
CapSoftware:mainfrom
yashranaway:fix/project-cli

Conversation

@yashranaway

@yashranaway yashranaway commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

opening a project recorded on windows on a mac or linux box can't find its media. the loader already converts backslash paths in the recording metadata, but when the path was already relative it built the fixed string and then threw it away. keyboard sidecar paths also skipped the check, so a moved project lost its keyboard overlay even when everything else resolved.

it keeps the converted path now and runs the same check on keyboard paths. three tests load metadata with both separators and read the files back. they fail on main.

🤖 Generated with Claude Code

RetriggerView in GreptileConfidence Score: 5/5

The PR appears safe to merge; no blocking issues were found.

Summary

This PR keeps converted Windows asset paths when loading a project and applies the same conversion to keyboard files.

  • Recording projects resolve media and keyboard files from their current folder.

Reviews (2) · Last reviewed commit: "fix(project): normalize Windows recordin..." · Reviewed by Greptile

@yashranaway

Copy link
Copy Markdown
Contributor Author

@greptileai review

@vercel

vercel Bot commented Oct 15, 2026

Copy link
Copy Markdown
Contributor

@yashranaway is attempting to deploy a commit to the Cap Software Inc Team on Vercel.

A member of the Team first needs to authorize it.

@richiemcilroy
richiemcilroy merged commit 509f49e into CapSoftware:main Oct 18, 2026
43 of 45 checks passed
@yashranaway
yashranaway deleted the fix/project-cli branch October 18, 2026 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants