Repository navigation
fix(project): normalize Windows recording asset paths - #2610
Merged
Merged
Conversation
Contributor
Author
|
@greptileai review |
Contributor
|
@yashranaway is attempting to deploy a commit to the Cap Software Inc Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
opening a project recorded on windows on a mac or linux box can't find its media. the loader already converts backslash paths in the recording metadata, but when the path was already relative it built the fixed string and then threw it away. keyboard sidecar paths also skipped the check, so a moved project lost its keyboard overlay even when everything else resolved.
it keeps the converted path now and runs the same check on keyboard paths. three tests load metadata with both separators and read the files back. they fail on main.
🤖 Generated with Claude Code


Confidence Score: 5/5
The PR appears safe to merge; no blocking issues were found.Summary
This PR keeps converted Windows asset paths when loading a project and applies the same conversion to keyboard files.
Reviews (2) · Last reviewed commit: "fix(project): normalize Windows recordin..." · Reviewed by Greptile