Fix/mooclet priors rebased by danoswaltCL · Pull Request #3093 · CarnegieLearningWeb/UpGrade

danoswaltCL · 2026-04-30T15:32:07Z

Apologies for giant PR, i got carried away

Adds a proper entry for priors per condition in the design page
Removes priors from overview and upsert experiment modal
Adds Reward Feedback Table improvements to show count, priors, posteriors, and estimated weight
Estimated weight is a new feature itself, the language of the tooltip explains it:
--

--

--

--

--

--

--

Copilot

Pull request overview

This PR updates Mooclet TS-configurable experiments to support per-condition priors, display prior/posterior counts and an estimated Thompson-sampling “weight” in the UI, and wires up a new modal for editing priors.

Changes:

Update shared upgrade_types to model prior and current_posteriors as Record<string, …> and extend rewards-summary rows with prior/posterior/estimated-weight fields.
Add a frontend “Edit condition prior” modal and integrate it into the experiment conditions section (plus i18n strings).
Add backend logic to fetch TS policy parameters and compute an estimated Thompson weight per condition for the rewards summary response.

Reviewed changes

Copilot reviewed 28 out of 28 changed files in this pull request and generated 11 comments.

Show a summary per file

File	Description
packages/types/src/index.ts	Re-export `Prior` / `CurrentPosteriors` for downstream usage.
packages/types/src/Mooclet/index.ts	Extend rewards-summary row type; remove `total` and add prior/posterior/estimated-weight fields.
packages/types/src/Mooclet/MoocletTSConfigurablePolicyParametersDTO.ts	Change `prior` to per-key record and add `current_posteriors` record.
packages/frontend/projects/upgrade/src/assets/i18n/en.json	Add labels/tooltips for priors, posteriors, and estimated weight + prior modal strings.
packages/frontend/projects/upgrade/src/app/shared/services/common-dialog.service.ts	Add dialog open helper for the new “edit condition prior” modal.
packages/frontend/projects/upgrade/src/app/features/dashboard/experiments/pages/.../ts-configurable-reward-count-table.component.ts	Add columns + tooltip generation for estimated weight.
packages/frontend/projects/upgrade/src/app/features/dashboard/experiments/pages/.../ts-configurable-reward-count-table.component.html	Render prior/posterior columns and estimated-weight column with tooltip.
packages/frontend/projects/upgrade/src/app/features/dashboard/experiments/pages/.../ts-configurable-reward-count-table.component.scss	Adjust table column sizing/formatting for the new columns.
packages/frontend/projects/upgrade/src/app/features/dashboard/experiments/pages/.../enrollment-condition-expandable-row.component.scss	Add hidden-column styling for mooclet-specific table behavior.
packages/frontend/projects/upgrade/src/app/features/dashboard/experiments/pages/.../enrollment-condition-expandable-row.component.html	Hide weight header/cell content for mooclet experiments.
packages/frontend/projects/upgrade/src/app/features/dashboard/experiments/pages/.../experiment-conditions-table.component.ts	Add prior input + editPrior output; switch displayed columns for mooclet experiments.
packages/frontend/projects/upgrade/src/app/features/dashboard/experiments/pages/.../experiment-conditions-table.component.html	Add prior success/failure columns and edit button for priors.
packages/frontend/projects/upgrade/src/app/features/dashboard/experiments/pages/.../experiment-conditions-table.component.scss	Add prior/prior-edit column sizing/alignment.
packages/frontend/projects/upgrade/src/app/features/dashboard/experiments/pages/.../experiment-conditions-section-card.component.ts	Wire conditions-section prior editing into dialog + experiment update.
packages/frontend/projects/upgrade/src/app/features/dashboard/experiments/pages/.../experiment-conditions-section-card.component.html	Pass prior into table and bind prior-edit event.
packages/frontend/projects/upgrade/src/app/features/dashboard/experiments/modals/upsert-experiment-modal/.../ts-configurable-policy-parameters-form.component.ts	Remove prior fields from the TS-configurable upsert form.
packages/frontend/projects/upgrade/src/app/features/dashboard/experiments/modals/upsert-experiment-modal/.../ts-configurable-policy-parameters-form.component.html	Remove prior inputs from the TS-configurable upsert form UI.
packages/frontend/projects/upgrade/src/app/features/dashboard/experiments/modals/edit-condition-prior-modal/edit-condition-prior-modal.component.ts	New modal component for editing per-condition priors.
packages/frontend/projects/upgrade/src/app/features/dashboard/experiments/modals/edit-condition-prior-modal/edit-condition-prior-modal.component.html	Modal UI for editing successes/failures priors per condition.
packages/frontend/projects/upgrade/src/app/features/dashboard/experiments/modals/edit-condition-prior-modal/edit-condition-prior-modal.component.scss	Styling for the prior-edit modal table/inputs.
packages/frontend/projects/upgrade/src/app/core/experiments/store/experiments.model.ts	Remove TS-configurable overview labels for global prior fields.
packages/frontend/projects/upgrade/src/app/core/experiments/mooclet-helper.service.ts	Remove flat prior fields and add validators for the new prior editor.
packages/frontend/projects/upgrade/src/app/core/experiments/mooclet-helper.service.spec.ts	Update tests to reflect removal of global prior fields.
packages/frontend/projects/upgrade/src/app/core/experiments/experiments.service.ts	Add store update helper to persist per-condition prior changes.
packages/backend/test/unit/services/MoocletRewardsService.test.ts	Update expected reward summaries to new shape (no `total`, add prior/posterior fields).
packages/backend/test/unit/services/MoocletExperimentService.test.ts	Update tests for per-condition prior keyed by version IDs + version-condition maps.
packages/backend/src/api/services/MoocletRewardsService.ts	Fetch policy params for rewards summary and compute estimated Thompson weights.
packages/backend/src/api/services/MoocletExperimentService.ts	Translate `prior`/`current_posteriors` keys between conditionCodes and versionIds.

Comments suppressed due to low confidence (1)

packages/frontend/projects/upgrade/src/app/core/experiments/mooclet-helper.service.ts:230

Method naming is inconsistent with the rest of the service (getTSConfigurableFieldValidators, etc.): getpriorFieldValidators should be getPriorFieldValidators (and likewise createpriorForm/openEditConditionpriorModal, etc.). Keeping standard camelCase improves readability and avoids accidental mismatches in call sites.

  /**
   * Get field validators for per-condition prior success/failure inputs used in the prior editor.
   */
  getpriorFieldValidators(): Record<string, ValidatorFn[]> {
    const priorDefault = 1;
    return {
      successes: [
        Validators.required,
        Validators.min(priorDefault),
        Validators.max(DEFAULT_MAX_NUMBER_INPUT),
        CommonFormHelpersService.integerValidator(),
      ],
      failures: [
        Validators.required,
        Validators.min(priorDefault),
        Validators.max(DEFAULT_MAX_NUMBER_INPUT),
        CommonFormHelpersService.integerValidator(),
      ],
    };

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-30T15:39:08Z

+        {{ CONDITION_TRANSLATION_KEYS.prior_SUCCESSES | translate }}
+      </th>
+      <td mat-cell *matCellDef="let condition" class="prior-column ft-14-400">
+        {{ getprioruccesses(condition) }}


Template references non-existent members: CONDITION_TRANSLATION_KEYS.prior_SUCCESSES and getprioruccesses(...) don't match the component (PRIOR_SUCCESSES and getPriorSuccesses). This will render blank headers / throw template errors at runtime/compile time. Update the template to use the correct constant key and method name.

Suggested change

{{ CONDITION_TRANSLATION_KEYS.prior_SUCCESSES | translate }}

</th>

<td mat-cell *matCellDef="let condition" class="prior-column ft-14-400">

{{ getprioruccesses(condition) }}

{{ CONDITION_TRANSLATION_KEYS.PRIOR_SUCCESSES | translate }}

</th>

<td mat-cell *matCellDef="let condition" class="prior-column ft-14-400">

{{ getPriorSuccesses(condition) }}

This still seems to be an issue, unless I'm looking at the wrong version of this branch.

bcb37 · 2026-05-04T20:39:00Z

Still working my way through this. Is the tooltip display supposed to show the the beta for a given condition? If so, it looks like the 'failure' value is always 0. (Or is that just a display to show the formulas, with 'blank' data?)

danoswaltCL · 2026-05-05T01:54:10Z

hm, it's odd also that it's showing 100%-0%, that can't be right. sigh, i'll look, i'm thinking that I should back out the estimation part of this and aim it at dev when it's more ready, the priors stuff is the bugfix I shouldn't have shoehorned this in.

danoswaltCL · 2026-05-05T13:11:49Z

(@bcb37 i am going to pull apart these things into different branches, so i set this in draft at the moment, will let you know)

bcb37

This looks ok to me, codewise. The validation on the modal when you input an invalid value seems a bit vague. It displays 'Value' in red.

danoswaltCL added 10 commits April 30, 2026 11:29

wip conditions priors

2b99bbd

fix priors naming to prior

518aae4

wip wip wip

f1271ca

style updates

aa7128c

style the table

10a8123

fix calculation error

02f09cb

remove moocletapi changes

5ffa710

fix unit tests remove total

94ca804

fix bad find-replace typos, refactor this and that

db6b7ca

correct tests

2e2965a

danoswaltCL requested review from bcb37, Copilot and zackcl and removed request for bcb37 and Copilot April 30, 2026 15:32

Copilot started reviewing on behalf of danoswaltCL April 30, 2026 15:32 View session

danoswaltCL mentioned this pull request Apr 30, 2026

Fix/mooclet priors #3089

Closed

Copilot AI reviewed Apr 30, 2026

View reviewed changes

danoswaltCL requested a review from bcb37 May 1, 2026 15:14

danoswaltCL added 3 commits May 1, 2026 12:41

correct bad "prior" renaming spots

487f3b7

add error handling for version condition mapping function

95223b7

update test posterior defaults

8117bd7

danoswaltCL marked this pull request as draft May 5, 2026 12:47

pull out estimated weights feature

e352c96

danoswaltCL marked this pull request as ready for review May 5, 2026 19:15

bcb37 reviewed May 6, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix/mooclet priors rebased#3093

Fix/mooclet priors rebased#3093
danoswaltCL wants to merge 14 commits intorelease/6.4from
fix/mooclet-priors-rebased

danoswaltCL commented Apr 30, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI Apr 30, 2026

Uh oh!

bcb37 May 4, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bcb37 commented May 4, 2026

Uh oh!

danoswaltCL commented May 5, 2026

Uh oh!

danoswaltCL commented May 5, 2026

Uh oh!

bcb37 left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

danoswaltCL commented Apr 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI Apr 30, 2026

Choose a reason for hiding this comment

Uh oh!

bcb37 May 4, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

bcb37 commented May 4, 2026

Uh oh!

danoswaltCL commented May 5, 2026

Uh oh!

danoswaltCL commented May 5, 2026

Uh oh!

bcb37 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

danoswaltCL commented Apr 30, 2026 •

edited

Loading