Feature/yarn clientjs scripts#3097
Open
danoswaltCL wants to merge 4 commits intodevfrom
Open
Conversation
bcb37
reviewed
May 4, 2026
Collaborator
bcb37
left a comment
bcb37
left a comment
There was a problem hiding this comment.
This looks convenient for some things.
| "install:all": "yarn && yarn --cwd clientlibs/js install", | ||
| "build": "yarn types build && concurrently \"yarn backend build\" \"yarn js-clientlib build\" \"yarn frontend build\"", | ||
| "launch": "concurrently -p \"[{name}]\" -n \"types,backend,frontend\" -c \"blue,magenta,cyan\" \"yarn types build\" \"yarn backend dev\" \"yarn frontend start\"", | ||
| "do-all-the-things": "yarn clean && yarn install:all && yarn build && yarn launch" |
Collaborator
There was a problem hiding this comment.
This is a bit vague (e.g. it doesn't run tests or build either of the other 2 client libs) and a lot to type: Maybe 'clean-launch?
Collaborator
Author
There was a problem hiding this comment.
i like clean-launch, will update
| "js-clientlib": "yarn --cwd clientlibs/js run", | ||
| "clean": "rm -rf node_modules clientlibs/js/node_modules packages/types/dist packages/backend/dist packages/frontend/dist clientlibs/js/dist", | ||
| "install:all": "yarn && yarn --cwd clientlibs/js install", | ||
| "build": "yarn types build && concurrently \"yarn backend build\" \"yarn js-clientlib build\" \"yarn frontend build\"", |
Collaborator
There was a problem hiding this comment.
We should be careful this top-level build doesn't get used for CI, since we don't want to necessarily build the js clientlib in the container.
Collaborator
Author
|
@bcb37 updated based on comments |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
yarnthe js clientlib default