apply sort before pagination in experiments and segments#3101
Open
apply sort before pagination in experiments and segments#3101
Conversation
Co-authored-by: Copilot <copilot@github.com>
danoswaltCL
previously approved these changes
May 6, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates backend pagination queries for segments and experiments so that sorting is applied before offset/limit, preventing inconsistent page contents when a sort is requested.
Changes:
- Apply
ORDER BYto the parent subquery used for pagination inSegmentService.findPaginated. - Refactor the experiments pagination subquery to use
GROUP BY experiment.id(instead ofDISTINCT) so it can be ordered by the requested sort key prior to pagination. - Add stable secondary ordering (
... , id ASC) for segments to ensure deterministic results when the primary sort key contains ties.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/backend/src/api/services/SegmentService.ts | Adds ordering (including id tiebreaker) to the paginated subquery and aligns the outer query ordering accordingly. |
| packages/backend/src/api/services/ExperimentService.ts | Refactors the paginated subquery to GROUP BY and orders by the requested sort key (and id) prior to applying pagination. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <copilot@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.