release: 0.12.0 — remove the React adapter's useBeverageLabelMap (CEL-1660) - #16
Conversation
|
Warning Review limit reachedNext included review available in 46 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Follow-up on the
I did not inspect any |
There was a problem hiding this comment.
No issues found across 2 files
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Auto-approved: Version bump to 0.12.0 with changelog finalization for the already-merged breaking removal; diff is limited to package metadata and changelog, with no code behavior change, so it is bounded and clearly beneficial.
Re-trigger cubic
|
Decisive diagnostic, no credentials involved: That is the whole gap. I did not look at either |
|
Update: #17 has merged, so the manual Verified no conflict against the new main ( Revised steps: Note |
Ready to merge, then publish — I could not publish it myself
This is the version bump for the CEL-1660 removal that landed in #15. Do not merge this without publishing, or
package.jsonwill claim 0.12.0 while the registry still serves 0.11.0, and any consumer bumped to^0.12.0will fail to install.Why it is a PR and not already released
npm publishfailed here withENEEDAUTH— this shell has no registry credential for@cellarnode. I deliberately did not investigate further, because inspecting.npmrcfiles means reading credentials. So I stopped, parked the commit here, and resetmainback to 0.11.0 so nothing drifts in the meantime.To finish (two steps)
Then verify against the registry rather than the cached packument:
Why 0.12.0 and not a patch
Removing a public export is breaking. Below 1.0 a caret does not cross a minor, so
^0.11.0consumers will not receive this automatically — which is the point. producer-dashboard, cellarnode-importer-dashboard and cellarnode-elabel-frontend each need an explicit^0.11.0→^0.12.0bump once this is live. admin-dashboard-v2 needs nothing (it never imported the package export — its local@/hooks/use-beverage-label-mapis a different module with the same name), and the mobile app does not depend on this package at all.A build bug I found and worked around
npm run builddoes not cleandist/. After #15 merged,dist/react/still contained the four removed artifacts (use-beverage-label-map.{js,d.ts,js.map,d.ts.map}, dated Apr 14) — orphaned but present.index.jsno longer references them, so nothing resolves through the package entry point, butprepublishOnlyruns onlybuild, so a publish from a dirty tree would have shipped the "removed" hook, still reachable by deep import.I ran
rm -rf dist && npm run buildbefore committing, and confirmed 0 matching files afterwards. Please do the same before publishing, since yourdist/is probably also stale.Worth a follow-up ticket: add a
cleanstep tobuild(orprepublishOnly) so a removal cannot survive into a published tarball. This repo has no Makefile and no release script — unlikeui, which hasrelease-patch/release-minor/release-majortargets that build, version, publish, commit and tag in one go. beverage-utils also has no release tags sincev0.1.0, so there is no way to bisect against a published version.Gates, run after the final commit
npm ci --legacy-peer-deps0 ·tsc --noEmit0 ·vitest run323/323 ·npm run build0 on a cleaned tree.Summary by cubic
Bumps
@cellarnode/beverage-utilsto 0.12.0, publishing the removal of the React adapter'suseBeverageLabelMapandbeverageLabelMapOptionsexports (CEL-1660).Rollout
producer-dashboard,cellarnode-importer-dashboard, andcellarnode-elabel-frontendmust bump from^0.11.0to^0.12.0;cellarnode-admin-dashboard-v2and the mobile app do not import the package.package.jsonahead of the registry, andnpm publishpreviously failed withENEEDAUTH.npm view @cellarnode/beverage-utils version --prefer-onlineafter publishing.Build
npm run builddoes not cleandist/, so runrm -rf dist && npm run buildbefore publishing to avoid shipping the removed hook via deep import.Written for commit 507eee8. Summary will update on new commits.