implemented property management

apps/server-mongodb-memory-mock/src/index.ts

@@ -6,15 +6,18 @@ setupEnvironment();
 
 const collectionsToSeed = ['users', 'communities', 'roles', 'members', 'properties', 'services'];
 
-const { PORT, DB_NAME, REPL_SET_NAME } = process.env;
+const { PORT, DB_NAME, REPL_SET_NAME, SKIP_DEV_SEED } = process.env;
 
 const port = Number(PORT ?? 50000);
 const dbName = DB_NAME ?? 'owner-community';
 const replSetName = REPL_SET_NAME ?? 'globaldb';
+// Test suites seed and reset the database themselves; the built-in dev seed
+// would otherwise fire once all collections exist and overwrite suite-managed
+// documents that reuse the same _ids mid-scenario.
+const skipDevSeed = SKIP_DEV_SEED === 'true';
 
 const config: MongoMemoryServerConfig = {
-	collectionsToSeed,
-	seedDatabase,
+	...(skipDevSeed ? {} : { collectionsToSeed, seedDatabase }),
 	port,
 	dbName,
 	replSetName,

apps/server-mongodb-memory-mock/src/seed/properties.ts

@@ -18,6 +18,7 @@ export const properties = [
 		listedForRent: true,
 		listedForLease: false,
 		listedInDirectory: true,
+		isDeleted: false,
 		location: {
 			position: {
 				type: 'Point',
@@ -92,6 +93,7 @@ export const properties = [
 		listedForRent: false,
 		listedForLease: false,
 		listedInDirectory: true,
+		isDeleted: false,
 		location: {
 			position: {
 				type: 'Point',

apps/ui-community/.storybook/apollo-mocks.ts

@@ -38,6 +38,8 @@ const mockMembers = [
 		__typename: 'Member' as const,
 		memberName: 'John Doe',
 		isAdmin: true,
+		accounts: [],
+		role: null,
 		id: 'member-1',
 		community: {
 			__typename: 'Community' as const,
@@ -48,6 +50,25 @@ const mockMembers = [
 		__typename: 'Member' as const,
 		memberName: 'Jane Smith',
 		isAdmin: false,
+		accounts: [
+			{
+				__typename: 'MemberAccount' as const,
+				statusCode: 'ACCEPTED',
+				user: { __typename: 'EndUser' as const, id: 'enduser-1' },
+			},
+		],
+		role: {
+			__typename: 'EndUserRole' as const,
+			id: 'role-property-manager',
+			permissions: {
+				__typename: 'EndUserRolePermissions' as const,
+				isNonPropertyAdmin: false,
+				propertyPermissions: {
+					__typename: 'EndUserRolePropertyPermissions' as const,
+					canManageProperties: true,
+				},
+			},
+		},
 		id: 'member-2',
 		community: {
 			__typename: 'Community' as const,
@@ -58,6 +79,8 @@ const mockMembers = [
 		__typename: 'Member' as const,
 		memberName: 'Bob Johnson',
 		isAdmin: true,
+		accounts: [],
+		role: null,
 		id: 'member-3',
 		community: {
 			__typename: 'Community' as const,
@@ -99,6 +122,7 @@ export const apolloMocks = [
 		},
 		result: {
 			data: {
+				currentEndUserAndCreateIfNotExists: mockCurrentEndUser,
 				membersForCurrentEndUser: mockMembers,
 			},
 		},

build-pipeline/core/monorepo-build-stage.yml

@@ -145,7 +145,7 @@ stages:
     # Playwright: Install browsers if needed
     - task: Bash@3
       displayName: 'Playwright: Install browsers if needed'
-      condition: and(ne(variables.PW_CACHE_HIT, 'true'), ne(variables.PW_CACHE_HIT, 'inexact'))
+      condition: and(succeeded(), ne(variables.PW_CACHE_HIT, 'true'), ne(variables.PW_CACHE_HIT, 'inexact'))
       inputs:
         targetType: 'inline'
         script: |
@@ -160,7 +160,7 @@ stages:
     # Playwright: Ensure browsers are available for packages that need them
     - task: Bash@3
       displayName: 'Playwright: Verify browser installation'
-      condition: always()
+      condition: succeeded()
       inputs:
         targetType: 'inline'
         script: |

codegen.yml

@@ -72,6 +72,7 @@ generates:
         Community: "import('@ocom/domain').Domain.Contexts.Community.Community.CommunityEntityReference"
         EndUser: "import('@ocom/domain').Domain.Contexts.User.EndUser.EndUserEntityReference"
         EndUserRole: "import('@ocom/domain').Domain.Contexts.Community.Role.EndUserRole.EndUserRoleEntityReference"
+        Property: "import('@ocom/domain').Domain.Contexts.Property.Property.PropertyEntityReference"
         StaffUser: "import('@ocom/domain').Domain.Contexts.User.StaffUser.StaffUserEntityReference"
     plugins:
       - typescript

knip.json

@@ -88,6 +88,7 @@
 			"entry": ["cucumber.js", "src/world.ts", "src/step-definitions/index.ts"],
 			"project": ["src/**/*.{ts,tsx,mjs}"],
 			"ignore": ["src/shared/support/ui/**"],
+			"ignoreDependencies": ["@ocom/ui-community-route-accounts", "@ocom/ui-community-route-admin", "@ocom/ui-community-route-root", "@ocom/ui-staff-route-root", "@ocom/ui-staff-route-user-management", "@ocom/ui-staff-shared"],
 			"ignoreUnresolved": ["progress-bar"]
 		},
 		"packages/ocom-verification/e2e-tests": {

packages/cellix/serenity-framework/src/servers/process-test-server.ts

@@ -33,6 +33,9 @@ export interface ProcessTestServerOptions {
 
 	/** Ports to clear before spawning, useful for fixed-port local dependencies. */
 	portsToCloseBeforeStart?: number | number[] | (() => number | number[]);
+
+	/** Extra environment variables applied over the inherited environment. */
+	env?: Record<string, string>;
 }
 
 /**
@@ -69,7 +72,7 @@ export class ProcessTestServer implements TestServer {
 
 		this.process = spawn(executable, spawnArgs, {
 			cwd: this.options.cwd,
-			env: createSpawnEnvironment(),
+			env: createSpawnEnvironment(this.options.env),
 			detached: this.useDetachedProcessGroup,
 			stdio: ['ignore', 'pipe', 'pipe'],
 		});

packages/ocom-verification/acceptance-api/package.json

@@ -26,18 +26,20 @@
 	},
 	"devDependencies": {
 		"@cellix/config-typescript": "workspace:*",
+		"@cellix/event-bus-seedwork-node": "workspace:*",
 		"@cellix/service-blob-storage": "workspace:*",
+		"@ocom-verification/verification-shared": "workspace:*",
 		"@ocom/application-services": "workspace:*",
 		"@ocom/context-spec": "workspace:*",
 		"@ocom/data-sources-mongoose-models": "workspace:*",
+		"@ocom/event-handler": "workspace:*",
 		"@ocom/graphql": "workspace:*",
 		"@ocom/persistence": "workspace:*",
 		"@ocom/service-apollo-server": "workspace:*",
 		"@ocom/service-blob-storage": "workspace:*",
 		"@ocom/service-mongoose": "workspace:*",
 		"@ocom/service-queue-storage": "workspace:*",
 		"@ocom/service-token-validation": "workspace:*",
-		"@ocom-verification/verification-shared": "workspace:*",
 		"@types/graphql-depth-limit": "^1.1.6",
 		"@types/node": "catalog:",
 		"c8": "^11.0.0",

packages/ocom-verification/acceptance-api/src/contexts/property/notes/property-notes.ts

@@ -0,0 +1,26 @@
+/** Input details used when updating a property through the API. */
+export interface PropertyUpdateDetails {
+	propertyName?: string | undefined;
+	propertyType?: string | null | undefined;
+	tags?: string[] | undefined;
+	bedrooms?: number | null | undefined;
+	bathrooms?: number | null | undefined;
+	squareFeet?: number | null | undefined;
+}
+
+/** Scenario-local property state shared between tasks and questions via actor notes. */
+export interface PropertyNotes {
+	activeCommunityId: string;
+	activeCommunityName: string;
+	actingMemberId: string;
+	lastPropertyStatus: string;
+	lastPropertyId: string;
+	lastPropertyName: string;
+	lastPropertyError: string;
+	listedPropertyNames: string[];
+	viewedPropertyId: string;
+	viewedPropertyName: string;
+	previousCommunityId: string;
+	previousMemberId: string;
+	submittedPropertyFields: Record<string, string>;
+}

packages/ocom-verification/acceptance-api/src/contexts/property/questions/properties-list.ts

@@ -0,0 +1,41 @@
+import { GraphQLClient } from '@cellix/serenity-framework/clients/graphql';
+import { type Actor, type AnswersQuestions, notes, Question, type UsesAbilities } from '@serenity-js/core';
+import { PROPERTIES_BY_COMMUNITY_ID_QUERY, type PropertyResult } from '../../../shared/graphql/property-operations.ts';
+import type { PropertyNotes } from '../notes/property-notes.ts';
+
+/**
+ * Question that reads the non-deleted properties of a community from the API.
+ * Defaults to the actor's active community recorded in notes.
+ */
+export class PropertiesList extends Question<Promise<PropertyResult[]>> {
+	static displayed(): PropertiesList {
+		return new PropertiesList(undefined);
+	}
+
+	static ofCommunity(communityId: string): PropertiesList {
+		return new PropertiesList(communityId);
+	}
+
+	private constructor(private readonly communityId: string | undefined) {
+		super('the properties list');
+	}
+
+	override async answeredBy(actor: AnswersQuestions & UsesAbilities): Promise<PropertyResult[]> {
+		const communityId = this.communityId ?? (await this.readActiveCommunityId(actor));
+		if (!communityId) {
+			throw new Error('No community id available to list properties. Did the actor become a property manager or member of a community first?');
+		}
+		const response = await GraphQLClient.as(actor as unknown as Actor).execute(PROPERTIES_BY_COMMUNITY_ID_QUERY, { communityId });
+		return response.data['propertiesByCommunityId'] as PropertyResult[];
+	}
+
+	override toString = () => 'the properties list';
+
+	private async readActiveCommunityId(actor: AnswersQuestions & UsesAbilities): Promise<string | undefined> {
+		try {
+			return await actor.answer(notes<PropertyNotes>().get('activeCommunityId'));
+		} catch {
+			return undefined;
+		}
+	}
+}

packages/ocom-verification/acceptance-api/src/contexts/property/questions/property-field.ts

@@ -0,0 +1,56 @@
+import { type AnswersQuestions, Question, type UsesAbilities } from '@serenity-js/core';
+import type { PropertyResult } from '../../../shared/graphql/property-operations.ts';
+import { PropertyNamed } from './property-named.ts';
+
+type ScalarField = 'propertyType';
+type ListingDetailField = 'bedrooms' | 'bathrooms' | 'squareFeet';
+
+/**
+ * Question that reads a single field of a named property live from the API.
+ * Fails with a diagnostic error when the property cannot be found.
+ */
+export class PropertyField extends Question<Promise<string | number | null>> {
+	static propertyType(propertyName: string): PropertyField {
+		return new PropertyField(propertyName, 'propertyType', undefined);
+	}
+
+	static bedrooms(propertyName: string): PropertyField {
+		return new PropertyField(propertyName, undefined, 'bedrooms');
+	}
+
+	static bathrooms(propertyName: string): PropertyField {
+		return new PropertyField(propertyName, undefined, 'bathrooms');
+	}
+
+	static squareFeet(propertyName: string): PropertyField {
+		return new PropertyField(propertyName, undefined, 'squareFeet');
+	}
+
+	private constructor(
+		private readonly propertyName: string,
+		private readonly scalarField: ScalarField | undefined,
+		private readonly listingDetailField: ListingDetailField | undefined,
+	) {
+		super(`the ${scalarField ?? listingDetailField} of the property "${propertyName}"`);
+	}
+
+	override async answeredBy(actor: AnswersQuestions & UsesAbilities): Promise<string | number | null> {
+		const property = await actor.answer(PropertyNamed.called(this.propertyName));
+		if (!property) {
+			throw new Error(`Property "${this.propertyName}" was not found in the properties list`);
+		}
+		return this.fieldOf(property);
+	}
+
+	override toString = () => `the ${this.scalarField ?? this.listingDetailField} of the property "${this.propertyName}"`;
+
+	private fieldOf(property: PropertyResult): string | number | null {
+		if (this.scalarField) {
+			return property[this.scalarField];
+		}
+		if (this.listingDetailField) {
+			return property.listingDetail?.[this.listingDetailField] ?? null;
+		}
+		throw new Error('PropertyField was constructed without a field');
+	}
+}