feat: add webhook response limits, CSRF docs, and IP-based auth blocking - #544
Merged
DeFiVC merged 4 commits intoOct 1, 2026
Conversation
Create webhook dispatcher with 1MB response body limit using AbortController for timeout and ArrayBuffer size checking. Protects against malicious endpoints sending unbounded responses. Refs ChainLearnOfficial#493
Document CSRF protection approach for cookie-based auth (currently Bearer tokens are CSRF-safe). Add admin endpoints to view and clear IP-based auth blocks. Refs ChainLearnOfficial#494, Refs ChainLearnOfficial#495
Track failed auth attempts per IP in Redis. After 10 failures within 5 minutes, temporarily block the IP for 5 minutes. Blocked requests return 429 with Retry-After header. Integrates with auth verify endpoint via preHandler check. Refs ChainLearnOfficial#495
|
@trustosaretin Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #493, Closes #494, Closes #495, Closes #508
Type of Change
Summary
This PR addresses four security and reliability issues: adds response size limits to webhook dispatch (#493), documents CSRF protection approach (#494), implements IP-based blocking for repeated auth failures (#495), and verifies schema.ts is clean of duplicate definitions (#508).
Motivation / Context
credentials: truebut no CSRF protection exists. Since auth uses Bearer tokens (CSRF-safe), this is documented as future-proofing guidance.Closes #493, Closes #494, Closes #495, Closes #508