Conversation
…nLearnOfficial#503) - Validate winning_votes > 0 in execute_proposal and panic with 'no votes cast' if zero votes were cast - Add test_execute_proposal_fails_with_zero_votes to verify zero-vote proposals cannot be executed - Repair test setup syntax and sequence alignment in token_tests.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #503.
In
execute_proposal(contracts/learn-token/src/lib.rs), after tallying all choices, we now validate thatwinning_votes > 0. If no votes were cast (winning_votes == 0), the function panics with"no votes cast". This prevents empty, unvoted proposals from being executed with a default winning choice of 0.Changes
contracts/learn-token/src/lib.rs: Added checkif winning_votes == 0 { panic!("no votes cast"); }after the tally loop inexecute_proposal.tests/unit/token_tests.rs: Added unit testtest_execute_proposal_fails_with_zero_votesverifying that proposals with 0 votes cannot be executed after the voting period ends.tests/unit/token_tests.rs: Cleaned up spliced function signatures and sequence numbers from recent upstream merge.Testing
cargo test --test token_tests: All 79 tests passed green.cargo clippy --test token_tests: 0 warnings.