Conversation
…rd (ChainLearnOfficial#502) - Call storage::append_claim_record inside the batch loop for each claimed quiz - Add test_batch_claim_reward_appends_claim_records_to_history to verify history is populated - Repair test setup syntax and sequence alignment in token_tests.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #502.
In
batch_claim_reward(contracts/learn-token/src/lib.rs), each successful quiz claim in the batch now appends aClaimRecordto the learner's claim history viastorage::append_claim_record, matching the behavior ofclaim_reward. This ensuresget_claim_historyreturns complete claim records regardless of whether rewards were claimed individually or in a batch.Changes
contracts/learn-token/src/lib.rs: Addedstorage::append_claim_recordcall inside the batch loop for each claimed quiz.tests/unit/token_tests.rs: Added unit testtest_batch_claim_reward_appends_claim_records_to_historyverifying that claims frombatch_claim_rewardare properly recorded inget_claim_history.tests/unit/token_tests.rs: Cleaned up spliced function signatures and sequence numbers from recent upstream merge.Testing
cargo test --test token_tests: All 79 tests passed green.cargo clippy --test token_tests: 0 warnings.