Skip to content

Require confirmation before switching the network toggle to mainnet - #463

Merged
DeFiVC merged 2 commits into
ChainLearnOfficial:mainfrom
defimomof2:fix/443-mainnet-switch-confirm
Sep 27, 2026
Merged

DeFiVC merged 2 commits into
ChainLearnOfficial:mainfrom
defimomof2:fix/443-mainnet-switch-confirm

Conversation

@defimomof2

@defimomof2 defimomof2 commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor
  • Switching the wallet network toggle from testnet to public/mainnet in connect-button.tsx now opens the existing ConfirmDialog instead of switching on a single click. The dialog explains that mainnet uses real funds and different contract addresses, that testnet balances won't carry over, and that transactions go to the live network and can't be reversed; the action is styled destructive and requires an explicit "Switch to Mainnet". Switching back to testnet stays one click (lower risk), and the current network is already shown in the wallet button badge and the menu row. Not type-checked or run locally (dependencies were not installed for this quick pass); it only composes existing components with their typed props. Closes Network toggle to mainnet has no confirmation dialog #443
  • [ ]Closes Quiz does not enforce time limit despite Quiz.timeLimitMinutes existing #441 — Quiz does not enforce time limit despite Quiz.timeLimitMinutes existing — to be completed
  • Closes Wallet network switch does not invalidate cached data #436 — Wallet network switch does not invalidate cached data — to be completed
  • Closes Double error notification on reward claim failure #435 — Double error notification on reward claim failure — to be completed

@drips-wave

drips-wave Bot commented Sep 26, 2026

Copy link
Copy Markdown

@defimomof2 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@netlify

netlify Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

❌ Deploy Preview for chainlearn failed.

Name Link
🔨 Latest commit 185b328
🔍 Latest deploy log https://app.netlify.com/projects/chainlearn/deploys/6ab8ced10d64160008274968

@DeFiVC
DeFiVC merged commit 6478fc7 into ChainLearnOfficial:main Sep 27, 2026
0 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants