fix: remove duplicate imports, params, and dead code in rewards.ts - #468
Merged
DeFiVC merged 1 commit intoSep 27, 2026
Merged
Conversation
|
@joelpeace48-cell Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
❌ Deploy Preview for chainlearn failed.
|
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
src/lib/api/rewards.tsfailed to compile:PaginatedResponseimport (lines 3 and 5)getRewardHistorydeclared two parameters namedparams, shadowing the first with an unusedGetRewardHistoryParamstypeapiClient.getcall (unclosed paren) followed by a second, complete implementationGetRewardHistoryParamswas dead — grep confirms the only real caller (src/lib/hooks/use-rewards.ts) usesgetRewardHistory(historyParams, jwt, signal)against theRewardHistoryParamsinterfaceFix: removed the duplicate import, the dead
GetRewardHistoryParamsinterface, the shadowed parameter, and the incomplete code block — keeping the single working implementation that matches the real call site's argument order and the exportedRewardHistoryParamstype.Closes #425
Closes #371
Closes #361
Closes #360