fix(types): remove duplicate EnrollmentStatus/QuizResult definitions - #470
Merged
DeFiVC merged 1 commit intoSep 28, 2026
Conversation
course.ts declared EnrollmentStatus twice and CourseEnrollment.status twice (required then optional); quiz.ts declared QuizResult as an interface then redefined it as a type alias. Kept the later, documented (ChainLearnOfficial#310) definitions in each file; no consumer referenced the removed EnrollmentStatus members ("active"/"dropped") or the removed QuizResult interface shape. Closes ChainLearnOfficial#427
|
@codemagician1949 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
❌ Deploy Preview for chainlearn failed.
|
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #427:
src/types/course.tsdeclaredEnrollmentStatustwice andCourseEnrollment.statustwice (required then optional);src/types/quiz.tsdeclaredQuizResultas an interface then redefined it as a type alias. Kept the later, documented (#310) definition in each case and removed the stale earlier one. Confirmed via grep that nothing consumes the removedEnrollmentStatusmembers (active/dropped) or the removedQuizResultinterface shape.Verified:
npx tsc --noEmit -p tsconfig.json— clean except one pre-existing, unrelated syntax error insrc/lib/api/client.test.ts(confirmed viagit logit was last touched by a different PR, no relation to these types).To be completed (not part of this PR, not closed by it)
abortRefinuseCoursescauses mutual cancellationRewardHistoryreceives aPaginatedResponseobject instead of an arraylib/utils/analytics.tsconversion tracking #372 — addlib/utils/analytics.tsconversion trackingCloses #427