feat: add Stellar wallet and formatting helpers - #502
Merged
Merged
Conversation
❌ Deploy Preview for chainlearn failed.
|
|
@Rampop01 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
npm ci --ignore-scripts --no-audit --no-fundsrc/lib/api/client.test.tsandsrc/lib/hooks/use-wallet-watcher.test.tsxlint parsing, and averification.isValid/validtype mismatch in the credential page. The dedicated test tsconfig also currently excludes its ownsrc/testsinputs.Compatibility note
The frontend backend-auth flow verifies a signed message. The supported LOBSTR and Rabet integrations connect and sign transactions, but their current wallet APIs do not support message signing, so those wallets cannot complete JWT login until the backend supports an authentication method they expose. Freighter authentication remains supported.
Fixes #345
Fixes #346
Fixes #347
Fixes #348