Build: autodetect Boost.Python version (fix boost_python312 hard-coding)#18
Open
siju-felsite wants to merge 1 commit into
Open
Build: autodetect Boost.Python version (fix boost_python312 hard-coding)#18siju-felsite wants to merge 1 commit into
siju-felsite wants to merge 1 commit into
Conversation
Hard-coding -lboost_python312 fails to link on hosts whose Boost.Python targets a different Python 3 minor version. Detect the active Python's major.minor and link boost_python<ver> accordingly. No behavioural change; verified by building and running the AES_Sbox_DOM_d1 example on Python 3.12.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hard-coding -lboost_python312 fails to link on hosts whose Boost.Python targets a different Python 3 minor version. Detect the active Python's major.minor and link boost_python accordingly. No behavioural change; verified by building and running the AES_Sbox_DOM_d1 example on Python 3.12.