fix(security): bind platform credential decryption to aad - #951
Open
AlanSyue wants to merge 2 commits into
Open
Conversation
…tial-aad-binding # Conflicts: # packages/encryption/src/encryption.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PlatformCredentialrow identity for both platform- and user-scoped credentialsRoot cause
PlatformCredentialwrite paths encrypt values with row-specific AAD, but the shared read path did not pass the expected context back into decryption. Without caller-provided context, decryption could fall back to the AAD embedded in the encrypted blob instead of binding the blob to the database row being read.The shared encryption utility now gives caller-provided AAD precedence while retaining its generic fallback when no AAD is supplied. This PR completes that contract by making the credential service always provide the expected row-derived AAD.
Impact
Validation
pnpm lintpnpm --filter @chatbotx.io/encryption check-typespnpm --filter @chatbotx.io/business check-typespnpm --filter @chatbotx.io/encryption test -- encryption— 22 tests passedpnpm --filter @chatbotx.io/business test -- platform-credential-service.test.ts— 872 tests passedgit diff --checkThe repository-wide coverage threshold was not bypassed. This PR does not claim a passing full coverage gate because the existing package baselines remain below the configured threshold.