Document OpenAPI model fragment scoping and fix anchor reference - #10216
Merged
Conversation
Contributor
Patch coverage100.0% of changed lines covered (1/1)
Project coverage: 54.4% (242289/445581 lines) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FragmentReferenceFinder.Find(document, fragment)reporting the anchor fragment as an external reference. The anchor was removed from the local lookup before the document was visited, so a sibling fragment spreading it was misread as a cross-document dependency, and the twoFindoverloads disagreed about the same document.--to#.Test plan
FragmentReferenceFinderTestscovering a document whose sibling fragment spreads the anchor; verified failing before the fix (Externalcontained the anchor) and passing after.HotChocolate.Adapters.OpenApi.Testssuite on net9.0, net10.0, and net11.0.prettier@3.8.3 --no-config --checkon the changed docs page.Reported in #10214. Not a full fix for that issue: how multi-fragment documents parse is a design decision still to be made, so this documents and names the current behavior rather than changing it.