fix: simplify Docker tagging — 'main' for branch, full tags for releases#95
Merged
Conversation
Main branch pushes now only build the default resolution (1600x960) and tag it as 'main'. Release builds (version tags) produce all resolutions with full tagging: latest, version, resolution, and version-resolution tags. This eliminates the overlap where resolution-only tags were overwritten by both main and release builds. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
ChrisRomp
force-pushed
the
chrisromp/docker-tag-strategy
branch
from
86c82af to
445a7b9
Compare
ChrisRomp
changed the title
There was a problem hiding this comment.
Pull request overview
This PR updates the Docker publishing workflow to simplify image tagging and reduce non-release branch builds.
Changes:
- Adds matrix filtering intended to build only the default resolution outside release tags.
- Changes Docker tag generation so non-release builds use
:main. - Keeps full resolution/version tagging for release tag builds.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/docker-publish.yml |
Updates build job filtering and Docker tag generation behavior. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 1/1 changed files
- Comments generated: 3
- Remove invalid job-level 'if' that referenced matrix context - All resolutions always build (PRs get full validation coverage) - Push decisions are centralized in tag generation step output - workflow_dispatch from non-main branches no longer overwrites :main - Sign step gated on push output for consistency Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Move tag generation step early (before cosign/login/buildx setup) - Add 'build' output to skip non-default resolution builds on main/dispatch - Gate cosign install and registry login on push==true (not just non-PR) - Gate buildx setup, artifact download, and docker build on build==true Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Simplifies the Docker image tagging strategy to eliminate tag overlap and reduce unnecessary builds on main branch pushes.
Before
latest1600x960tag was overwritten by both main and release buildsAfter
mainmainv1.2.3latest,v1.2.3,1600x960,v1.2.3-1600x960<resolution>,v1.2.3-<resolution>Changes
ifto skip non-default resolution matrix entries on non-release buildsmaintag; releases get full version/resolution tagginglatestnow only reflects GitHub releases, not branch builds