Skip to content

fix(stream): viewer live-stream rotation missed the data/ segment #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChronodeAi merged 2 commits into from
Aug 25, 2026
Merged

fix(stream): viewer live-stream rotation missed the data/ segment #15

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
260beb4
fix(stream): resolve viewer live stream under <data-dir>/data/stream_…
ChronodeAi Aug 25, 2026
0072822
chore(evidence): refresh inventory after stream path fix
ChronodeAi Aug 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .aiwg/reports/g-icm-01-interface-inventory.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@
"control_id": "G-ICM-01",
"project_id": "github.com/chronodeai/agentmemory",
"source_identity": {
"commit_sha": "facabd34882d1e66a5ec3d4821eecde235fed1b1",
"commit_tree_sha": "b58a99a88f05e094b42be7c52e72784d87cc4e6d",
"inventory_input_sha256": "2e776824dd49040af5451aab80bbbe2e2f0dcab5aab982653711558baa74625b"
"commit_sha": "260beb4a954eca7a71019b89f8e09df8c65c10bb",
"commit_tree_sha": "1b692f290d11ae470cb2009156266d6de039ebe7",
"inventory_input_sha256": "8091d93e47a45cd4cb2d4c38cab6448af9186743c84d73406ed2ea2a269fc51e"
},
"public_route_allowlist": [
"GET /agentmemory/livez"
Expand Down
2 changes: 1 addition & 1 deletion ci/r13-test-manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"count": 180,
"sha256": "e8489acf3396ad149ca9342214e4865124021fd1e05d37ff548e63dcf2f6a242",
"content_sha256": "43402e473a95ebcfa5a7a27c1a7cf0f0a056ffdd9b95ed6fd5f8ade4ddcc2b10"
"content_sha256": "480974ca30f7632c133fd0fcd7aff9bb03b99c04783d7f86a005134fb4b5e87e"
}
3 changes: 3 additions & 0 deletions src/state/live-stream-rotation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,11 @@ export function resolveLiveStreamMaxBytes(
}

export function viewerLiveStreamPath(dataDir: string = resolveDataDir()): string {
// The stream store lives under <data-dir>/data/stream_store — the same
// layout iii-runtime-config materializes and health resources inventory.
return join(
dataDir,
"data",
"stream_store",
`stream%3A${STREAM.name}%3A${STREAM.viewerGroup}.bin`,
);
Expand Down
8 changes: 5 additions & 3 deletions test/live-stream-rotation.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,14 +63,16 @@ describe("resolveLiveStreamMaxBytes", () => {
});

describe("viewerLiveStreamPath", () => {
it("mirrors the iii-stream file-backed adapter layout", () => {
expect(viewerLiveStreamPath("/data")).toBe(join("/data", "stream_store", VIEWER_STREAM_NAME));
it("mirrors the iii-stream file-backed adapter layout under <data-dir>/data", () => {
expect(viewerLiveStreamPath("/root")).toBe(
join("/root", "data", "stream_store", VIEWER_STREAM_NAME),
);
});
});

describe("rotateLiveStreamIfOversized", () => {
function seedStream(dataDir: string, bytes: number): string {
const store = join(dataDir, "stream_store");
const store = join(dataDir, "data", "stream_store");
mkdirSync(store, { recursive: true });
const filePath = join(store, VIEWER_STREAM_NAME);
writeFileSync(filePath, Buffer.alloc(bytes, 0x61));
Expand Down
Loading