docs: document real root cause for test_prv_006/007 concurrent failures - #106
Merged
Merged
Conversation
Both were pulled from the default smoke gate as a stopgap (PR #100) pending investigation. Root cause is now confirmed: DataSpaceBackend#199, a same-second slug/title collision on dataset/usecase creation that makes the create mutation fail outright under concurrent load - not a network-latency issue, so the earlier 30s->60s wait bump never could have fixed it. Fix is up as DataSpaceBackend PR #203 (not yet merged/deployed). Leaving both tests as functional-only until #203 lands on dev and they're confirmed green under -n 3 concurrent load - re-adding @pytest.mark.smoke now would be speculative.
DataSpaceBackend PR #203 (retry-with-disambiguated-slug on same-second title collision) merged to dev and deployed 2026-09-18. Confirmed via the deploy's own post-deploy Functional Tests gate (DataSpaceBackend run 35334824692, job 105572848166): test_prv_006_org_create_dataset and test_prv_007_org_create_usecase both PASSED under real -n 3 concurrent load against the now-fixed dev backend, 0 reruns needed - a clean pass where every prior attempt failed 3/3 including reruns. Re-adding @pytest.mark.smoke to both, back under the default PR/push gate. Updated the explanatory comments to describe the fix as landed rather than pending.
saqibmanan
marked this pull request as ready for review
September 18, 2026 12:42
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Comment-only update, no marker/logic changes.
test_prv_006_org_create_datasetandtest_prv_007_org_create_usecasewere pulled from the default smoke gate in #100 as a stopgap pending investigation, with a comment saying they "need their own investigation." That investigation is done:addDataset/addUseCase/addCollaborative's auto-generated titles have 1-second resolution, and the derived slug (and, for use cases, the title itself) is a unique DB column. Two creates in the same second — routine with-n 3concurrent provider-smoke workers — collide on that constraint.addDatasetreturnssuccess: Falsewith an unusable error;addUseCasehas no error handling at all and just raises. Either way the frontend's create flow never gets a usable record, which is exactly the "Timed out waiting for Metadata tab" and "Summary mismatch, Found: ''" symptoms these two tests hit.What this PR does NOT do
Does not re-add
@pytest.mark.smoke— that should only happen once #203 is merged, deployed to dev, and these two tests are confirmed green under real-n 3concurrent CI load. Draft, not for merge yet.Test plan
git diffis docstring/comment lines only)-n 3against dev once #203 deploys, then flip the marker back to smoke in a follow-up PR