Skip to content

fix: tests/consumer/functional was in no CI job path - #96

Merged
saqibmanan merged 1 commit into
CIfrom
fix/consumer-functional-in-ci-path
Sep 17, 2026
Merged

saqibmanan merged 1 commit into
CIfrom
fix/consumer-functional-in-ci-path

Conversation

@saqibmanan

Copy link
Copy Markdown
Contributor

Closes #23.

consumer-smoke's default (unset-suite) case hardcoded p="tests/consumer/smoke" — every other explicit suite case (smoke/functional/full/readonly) already used the broader p="tests/consumer". Only the legacy default narrowed it, and that's the case both plain pushes and unset dispatch/call runs fall into.

The 3 registration + privacy-consent tests added in #21/PR#20 (tests/consumer/functional/test_con_registration.py) have never run in CI since — the marker filter already correctly widens to "smoke or functional" on workflow_dispatch/workflow_call, but the path never let pytest see the file at all.

Fix

Bring the default case's path in line with the other four.

Verified via collection, not just by reading

Push/PR shape (-m "smoke" against tests/consumer) — 0 functional tests collected. No change to everyday behaviour, exactly as intended.

Dispatch/call shape (-m "smoke or functional") — all 4 functional tests now collected, where 0 collected before this fix:

tests/consumer/functional/test_con_consumer_login_needed.py::test_con_001_consumer_login
tests/consumer/functional/test_con_registration.py::TestPrivacyConsentEnforcement::test_registration_is_blocked_without_consent
tests/consumer/functional/test_con_registration.py::TestRegistrationFlow::test_registration_with_consent_creates_an_account
tests/consumer/functional/test_con_registration.py::TestRegistrationFlow::test_registration_requires_email_verification

actionlint: zero findings.

consumer-smoke's default (unset-suite) case hardcoded
p="tests/consumer/smoke" -- every other explicit suite case already
used the broader p="tests/consumer", only this one legacy default
narrowed it. The three registration + privacy-consent tests added in
#21/PR#20 (tests/consumer/functional/test_con_registration.py) have
never executed in CI since, despite the marker filter already
correctly widening to "smoke or functional" on workflow_dispatch/
workflow_call -- the path never let pytest see the file at all.

Fix: bring the default case's path in line with the rest.

Verified via collection, not just by reading:
- -m "smoke" against tests/consumer (push/PR shape): 0 functional
  tests collected -- no change to everyday behaviour.
- -m "smoke or functional" (dispatch/call shape): all 4 functional
  tests collected (the 3 registration tests + the pre-existing login
  test), where 0 collected before this fix.
@saqibmanan saqibmanan self-assigned this Sep 17, 2026
@saqibmanan
saqibmanan marked this pull request as ready for review September 17, 2026 08:47
@saqibmanan
saqibmanan merged commit 90ca722 into CI Sep 17, 2026
3 checks passed
@saqibmanan
saqibmanan deleted the fix/consumer-functional-in-ci-path branch September 17, 2026 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant