fix: tests/consumer/functional was in no CI job path - #96
Merged
Merged
Conversation
consumer-smoke's default (unset-suite) case hardcoded p="tests/consumer/smoke" -- every other explicit suite case already used the broader p="tests/consumer", only this one legacy default narrowed it. The three registration + privacy-consent tests added in #21/PR#20 (tests/consumer/functional/test_con_registration.py) have never executed in CI since, despite the marker filter already correctly widening to "smoke or functional" on workflow_dispatch/ workflow_call -- the path never let pytest see the file at all. Fix: bring the default case's path in line with the rest. Verified via collection, not just by reading: - -m "smoke" against tests/consumer (push/PR shape): 0 functional tests collected -- no change to everyday behaviour. - -m "smoke or functional" (dispatch/call shape): all 4 functional tests collected (the 3 registration tests + the pre-existing login test), where 0 collected before this fix.
saqibmanan
marked this pull request as ready for review
September 17, 2026 08:47
This was referenced Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #23.
consumer-smoke's default (unset-suite) case hardcodedp="tests/consumer/smoke"— every other explicit suite case (smoke/functional/full/readonly) already used the broaderp="tests/consumer". Only the legacy default narrowed it, and that's the case both plain pushes and unset dispatch/call runs fall into.The 3 registration + privacy-consent tests added in #21/PR#20 (
tests/consumer/functional/test_con_registration.py) have never run in CI since — the marker filter already correctly widens to"smoke or functional"onworkflow_dispatch/workflow_call, but the path never let pytest see the file at all.Fix
Bring the default case's path in line with the other four.
Verified via collection, not just by reading
Push/PR shape (
-m "smoke"againsttests/consumer) — 0 functional tests collected. No change to everyday behaviour, exactly as intended.Dispatch/call shape (
-m "smoke or functional") — all 4 functional tests now collected, where 0 collected before this fix:actionlint: zero findings.