feat: deploy gating model — readonly prod + rollback, two-stage dev, PR gate - #460
Merged
Merged
Conversation
Prod had no tests at all: a release was marked last-known-good straight after deploy. Now main runs only the readonly allowlist against prod and promotes on pass or rolls back on failure; dev runs smoke, then functional only if smoke passed. api_base_url is explicit per branch -- run-smoke's api job otherwise falls back to the dev API.
Provider functional tests fail at shifting points against dev (autosave races, slow create flows), so gating on them would roll back dev deploys spuriously. The gating functional stage and the PR gate now skip provider; separate provider jobs run with only_provider and report, without being a dependency of rollback/promote or a required check.
Finalize and rollback did not list the report-only provider job in needs, so a deploy asked for finalize approval while provider tests were still running. Both now wait for it, and condition on the gating jobs' results explicitly instead of failure()/!failure(), which would count the report-only job's result.
…pproval production requires a reviewer, and every job referencing it asked again: approve the deploy, then approve finalize or rollback -- so a failing prod deploy stayed live until someone clicked. production-ops holds the same host and SSH secrets with no reviewer and a main-only branch policy; the human approval stays on the deploy job.
…second approval" This reverts commit c05c0c7.
org_add_permission needs a Keycloak token to check canAdd. A called workflow only sees secrets its caller passes, and the report-only job passed none, so every org-create test skipped on both workers -- the provider report looked green while never exercising org flows.
Same gap as the deploy workflow's report job: without it every org-create test skips on both workers.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deploy gating model for DataSpaceFrontend:
readonlyallowlist runs against prod, thenpromote(marks.last_good) on pass orrollback(reverts thereleases/symlink) on failure.pr-gate.yml): every PR intomainruns the full suite against dev; provider reports separately and won't be a required check.api_base_urlis now explicit per branch — run-smoke's api job otherwise falls back to the dev API, which would have tested dev's backend while gating a prod deploy.Uses CivicDataSpace-test's
suite/only_providerinputs (#76, #78).