Skip to content

revert: keep prod finalize/rollback in the production environment #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
saqibmanan merged 1 commit into from
Sep 15, 2026
Merged

revert: keep prod finalize/rollback in the production environment #461

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions .github/workflows/deploy-Dataspace.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,9 +260,7 @@ jobs:
# vars.EC2_HOST is an environment-scoped variable, only visible to jobs
# that declare `environment:` -- without it appleboy/ssh-action fails
# with "missing server host".
# production-ops: same prod host/SSH secrets, no required reviewer, main-only.
# The human approval is on the deploy job; finalize/rollback must not wait.
environment: ${{ github.ref_name == 'main' && 'production-ops' || 'development' }}
environment: ${{ github.ref_name == 'main' && 'production' || 'development' }}
steps:
- name: Mark this release as last-known-good
uses: appleboy/ssh-action@v1.0.3
Expand All @@ -283,9 +281,7 @@ jobs:
runs-on: ubuntu-latest
# Same environment-scoped vars.EC2_HOST issue as promote - see the
# comment there.
# production-ops: same prod host/SSH secrets, no required reviewer, main-only.
# The human approval is on the deploy job; finalize/rollback must not wait.
environment: ${{ github.ref_name == 'main' && 'production-ops' || 'development' }}
environment: ${{ github.ref_name == 'main' && 'production' || 'development' }}
steps:
- name: Revert to last known-good release
uses: appleboy/ssh-action@v1.0.3
Expand Down
Loading