Accessibility-fix-in-code - #469
Open
UdayRajSahai2 wants to merge 1 commit into
Open
UdayRajSahai2 wants to merge 1 commit into
UdayRajSahai2 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes accessibility issues reported in the audit without changing how the site looks (no bigger breadcrumbs, footer icons, or zoom). Sighted users should see the same UI. Screen readers and keyboard users get clearer structure and names.
Headings and landmarks
Header and mobile menu links were rendered as h1. They are now span so each page has one real title, not five.
Home, About, Collaboratives, Publishers, Sectors, and Use Cases use the existing title as a single h1 (variant for size, as="h1" for meaning).
Datasets has no visible title, so it gets a visually hidden h1.
Nested main on listing/about pages was changed to div because the layout already has main.
Default document title/description added in the locale layout for pages that did not set one.
Forms and buttons
Search fields with empty labels now use label="Search" (the visible label stays hidden).
Sort dropdowns use label="Sort" + labelHidden so they have a name without a second “Sort” on screen.
Footer social icons get aria-labels (GitHub, LinkedIn, Twitter, Facebook). Icon size is unchanged.
Profile menu: the clickable control is the button itself, not a wrapper div (invalid ARIA). Menu content is the same; some lines only look new because of indent.
Keyboard focus
Home search, metric cards, and “Explore all …” links show a 2px focus ring only when you Tab, not on mouse click.
Third-party markup
holy-loader injects an invalid role="bar". We set aria-hidden on #holy-progress so screen readers skip the visual loading bar. Sighted users still see the green line. Tooltip components still come from opub-ui; only the global tooltip provider uses Radix so we do not get a second main.
Visual safety
Small h1 reset in globals.css so browser default heading styles do not enlarge titles (Tailwind preflight is off).