Skip to content

fix: sort AI model and evaluation domain dropdowns alphabetically #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anishkb-dev wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix: sort AI model and evaluation domain dropdowns alphabetically #441

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions app/[locale]/dashboard/ai-maker/[orgId]/evaluations/components/ModelSelectionModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ const parseDomainOptions = (domains: unknown[]): SelectOption[] => {
}
});

return options;
return options.sort((a, b) => a.label.localeCompare(b.label));
};

interface ModelSelectionModalProps {
Expand Down Expand Up @@ -562,10 +562,12 @@ const ModelSelectionModal = ({
className={
lockModelSelection ? 'mode-of-evaluation-select-disabled' : undefined
}
options={aiModels.map((model) => ({
value: model.id,
label: model.displayName || model.name,
}))}
options={aiModels
.map((model) => ({
value: model.id,
label: model.displayName || model.name,
}))
.sort((a, b) => a.label.localeCompare(b.label))}
value={selectedModelId || ''}
onChange={(value) => {
setSelectedModelId(value);
Expand Down
12 changes: 8 additions & 4 deletions app/[locale]/dashboard/ai-maker/[orgId]/evaluations/components/NewEvaluationContent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -417,6 +417,8 @@ const NewEvaluationContent: React.FC<NewEvaluationContentProps> = ({
}
});

options.sort((a, b) => a.label.localeCompare(b.label));

setEvaluationScopeOptions(options);
} catch {
setEvaluationScopeOptions([]);
Expand Down Expand Up @@ -2137,10 +2139,12 @@ const NewEvaluationContent: React.FC<NewEvaluationContentProps> = ({
<Select
name="modelSelect"
label="Select AI Model"
options={aiModels.map((model) => ({
value: model.id,
label: model.displayName || model.name,
}))}
options={aiModels
.map((model) => ({
value: model.id,
label: model.displayName || model.name,
}))
.sort((a, b) => a.label.localeCompare(b.label))}
value={selectedModelId || ''}
onChange={(value) => {
setSelectedModelId(value);
Expand Down