Railcraft compat by LonelyxiyaOVO · Pull Request #384 · CleanroomMC/GroovyScript

LonelyxiyaOVO · 2026-05-05T12:26:36Z

bro Railcraft compat

Wizzerinus

I'm not a maintainer of this mod, just mentioning some things I noticed ;)

Wizzerinus · 2026-05-05T12:30:38Z

+    }
+
+    @MethodDescription(example = @Example("item('railcraft:ingot:1')"))
+    public void removeByOutput(ItemStack output) {


afaik removeBy... methods usually should return a boolean

Wizzerinus · 2026-05-05T12:32:35Z

+            return;
+        }
+        if (!getRecipes().removeIf(recipe -> {
+            if (recipe.getInput().test(input.getMatchingStacks()[0])) {


Good idea to either adjust the function to accept an ItemStack, or test against each matching stack

Wizzerinus · 2026-05-05T12:33:33Z

missing lang files for all compat scripts. they're needed to generate the wiki (you can test this in a dev env by using /gs generateWiki)

Wizzerinus · 2026-05-05T12:34:50Z

+        public @Nullable IBlastFurnaceCrafter.IRecipe register() {
+            if (!validate()) return null;
+            ItemStack outputStack = output.get(0);
+            Ingredient inputIngredient = Railcraft.toIngredient(input.get(0));


I'm pretty sure there's already a way in Groovyscript to make Forge ingredients

Wizzerinus · 2026-05-05T12:35:19Z

+            IBlastFurnaceCrafter.IRecipe recipe = new IBlastFurnaceCrafter.IRecipe() {
+                @Override
+                public net.minecraft.util.ResourceLocation getName() {
+                    return new net.minecraft.util.ResourceLocation("groovyscript", "blastfurnace_" + System.currentTimeMillis());


possibly allow configuring the recipe name similar to crafting table

definitely do this

Wizzerinus · 2026-05-05T12:35:53Z

+        public void validate(GroovyLog.Msg msg) {
+            validateItems(msg, 1, 1, 1, 1);
+            validateFluids(msg);
+            if (time < 0) time = 1800;


if (time < 0) should emit a error instead

Wizzerinus · 2026-05-05T12:36:04Z

+            if (time < 0) time = 1280;
+            if (slag < 0) slag = 1;


should emit errors on these

Wizzerinus · 2026-05-05T12:37:12Z

+        // Restore from backup
+        restoreFromBackup().forEach(entry -> {
+            try {
+                mods.railcraft.api.fuel.FluidFuelManager.addFuel(entry.fluid, entry.heatValue);


any reason you're not importing this?

Wizzerinus · 2026-05-05T12:39:40Z

+        Crafters.rollingMachine().getRecipes().clear();
+    }
+
+    public static class ShapedRecipeBuilder {


could use the AbstractShapedRecipeBuilder to not have to manage matrix/etc manually? (I'm not sure what's the name of it is, but it is used for MC tables, Astral Sorcery tables, etc)

WaitingIdly

a few other things:

instead of magic numbers as defaults, use the railcraft defaults directly - ie IRollingMachineCrafter.DEFAULT_PROCESS_TIME.
run /gs generateWiki or enabling dev_generate_wiki in gradle.properties - check the log to ensure no warnings/missing lang keys.
wizz also brought up great points, listen to those.

WaitingIdly · 2026-05-05T13:50:21Z

 debug_prodigytech = false
 debug_projecte = false
 debug_pyrotech = false
+debug_railcraft = false


WaitingIdly · 2026-05-05T13:50:26Z

        'tinkers_construct-74072:2902483'                     : [debug_tinkers_construct],
-        'woot-244049:2712670'                                 : [debug_woot],
+        'railcraft-51195:3853491'                             : [debug_railcraft],
+        'woot-244049:2712670'                                   : [debug_woot],


WaitingIdly · 2026-05-05T13:52:03Z

this should only contain the generated script, which is obtained via ie /gs generateExamples or by enabling dev_generate_examples in gradle.properties.

WaitingIdly · 2026-05-05T13:53:24Z

+        builder.time = time;
+        builder.slag = slag;


call builder methods instead. this applies in all places, to all builders. observe how other similar methods do this

WaitingIdly · 2026-05-05T13:54:18Z

+        @Property(comp = @Comp(gte = 0))
+        private int time = 1280;
+        @Property(comp = @Comp(gte = 0))
+        private int slag = 1;


add defaultValue = "whatever" to the annotation whenever a builder field is non-default

WaitingIdly · 2026-05-05T14:10:44Z

+
+        @Property(comp = @Comp(gte = 0))
+        private int time = 200;
+        private final List<IOutputEntry> outputs = new ArrayList<>();


annotate this with @Property. i would also suggest renaming this to output

WaitingIdly · 2026-05-05T14:12:38Z

+            List<IRollingMachineCrafter.IRollingRecipe> recipes = new ArrayList<>(Crafters.rollingMachine().getRecipes());
+            recipes.removeIf(recipe -> recipe.getRegistryName().equals(r.getKey()));


create a new arraylist and then remove from that list? are you sure thats correct

WaitingIdly · 2026-05-05T14:13:28Z

+            List<IRollingMachineCrafter.IRollingRecipe> recipes = new ArrayList<>(Crafters.rollingMachine().getRecipes());
+            recipes.removeIf(recipe -> recipe.getRegistryName().equals(r.getKey()));
+        });
+        restoreFromBackup().forEach(r -> ModSupport.RAILCRAFT.get().rollingMachine.add(r.getKey(), r.getValue()));


cant do this, because RollingMachine#add runs #addScripted

WaitingIdly · 2026-05-05T18:13:31Z

+        if (time <= 0) {
+            GroovyLog.msg("Error adding Railcraft Blast Furnace recipe")
+                    .error()
+                    .add("time must be greater than 0, got: {}", time)
+                    .post();
+            return null;
+        }
+        if (slag < 0) {
+            GroovyLog.msg("Error adding Railcraft Blast Furnace recipe")
+                    .error()
+                    .add("slag must be non-negative, got: {}", slag)
+                    .post();
+            return null;
+        }


validate in the builder

WaitingIdly · 2026-05-05T18:14:46Z

+            if (time <= 0) {
+                msg.add("time must be greater than 0, got: {}", time);
+                time = IBlastFurnaceCrafter.SMELT_TIME;
+            }
+            if (slag < 0) {
+                msg.add("slag must be non-negative, got: {}", slag);
+                slag = 1;
+            }


if there are any messages, the validation fails. just do

Suggested change

if (time <= 0) {

msg.add("time must be greater than 0, got: {}", time);

time = IBlastFurnaceCrafter.SMELT_TIME;

}

if (slag < 0) {

msg.add("slag must be non-negative, got: {}", slag);

slag = 1;

}

msg.add(time <= 0, "time must be greater than 0, got: {}", time);

msg.add(slag < 0, "slag must be non-negative, got: {}", slag);

WaitingIdly · 2026-05-05T18:16:12Z

+        @Property
+        private FluidStack fluid;


instead of this, use fluidOutput from parent

WaitingIdly · 2026-05-05T18:16:28Z

+@RegistryDescription
+public class FluidFuels extends VirtualizedRegistry<FluidFuels.FuelEntry> {
+
+    private final Map<String, Integer> backupFuels = new HashMap<>();


this is now completely unused

WaitingIdly · 2026-05-05T18:17:36Z

+
+    public boolean remove(IRollingMachineCrafter.IRollingRecipe recipe) {
+        return Crafters.rollingMachine().getRecipes().removeIf(r -> {
+            if (r == recipe) {


if r == recipe well you can just do addBackup(recipe) + Crafters.rollingMachine().getRecipes().remove(recipe) then

WaitingIdly · 2026-05-05T18:17:59Z

 # Version of your mod.
 # This field can be left empty if you want your mod's version to be determined by the latest git tag instead.
-modVersion = 1.4.3
+modVersion = 1.4.4


undo changing the version

LonelyxiyaOVO added 3 commits May 5, 2026 20:11

Railcraft compat

77aeaa5

Fix bug

f7c3701

Update railcraft_example.groovy

17e5d27

Wizzerinus reviewed May 5, 2026

View reviewed changes

WaitingIdly requested changes May 5, 2026

View reviewed changes

LonelyxiyaOVO added 5 commits May 6, 2026 00:06

optimize code

09cdcb9

Functional and logical bug fixes

dd77b78

Update FluidFuels.java

4ab6ae2

Update FluidFuels.java

99933e7

Update buildscript.properties

84d43bb

WaitingIdly requested changes May 5, 2026

View reviewed changes

		List<IRollingMachineCrafter.IRollingRecipe> recipes = new ArrayList<>(Crafters.rollingMachine().getRecipes());
		recipes.removeIf(recipe -> recipe.getRegistryName().equals(r.getKey()));

Conversation

LonelyxiyaOVO commented May 5, 2026

Uh oh!

Wizzerinus left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

WaitingIdly left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants