Repository navigation
[CLEARFACTS-13218] Upgrades - #8
Merged
Merged
Conversation
…parser@10 path)
Nulled 5 rules in package.json stylelint.rules that produced violations
on unmodified files but did not exist in the v9 toolchain:
- property-no-deprecated (new core rule, absent from stylelint@9.10.1)
- declaration-property-value-keyword-no-deprecated (new core rule, absent
from stylelint@9.10.1)
- scss/no-global-function-names (new stylelint-scss rule, absent from
stylelint-scss@3.5.1)
- scss/load-partial-extension (new stylelint-scss rule, absent from
stylelint-scss@3.5.1)
- scss/operator-no-unspaced (rule existed in stylelint-scss@3.5.1 but was
not enabled by stylelint-config-recommended-scss@3.2.0 nor by this
project's config; only newly enabled via v17's recommended-scss config)
NOT nulled, left for follow-up: declaration-block-no-shorthand-property-overrides
and selector-pseudo-class-no-unknown. Both were already part of the active
v9-era config (enabled via stylelint-config-recommended, which
stylelint-config-recommended-scss extends) -- confirmed by running the actual
stylelint@9.10.1 binary with this project's identical config against these
same unmodified files (0 violations). v17's improved rule implementations now
correctly catch 3 pre-existing real defects: border-color overridden by the
border shorthand (Message.scss:781), overflow-y overridden by the overflow
shorthand (Thread.scss:8), and a bare `:placeholder` that should be
`::placeholder` (MessageInput.scss:82). `yarn stylelint '**/*.{css,scss}'`
therefore still exits 2. Not suppressed here since that would silence
already-configured lint coverage as an unplanned side effect of a dependency
bump, and editing the .scss files is out of scope for this task.
… node-fetch, cipher-base, pbkdf2, tar)
…avis, ignore files)
Isaakske
approved these changes
Jul 29, 2026
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.