Skip to content

Allow group members to record settlements on behalf of the payer #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ClementLSW merged 1 commit into from
May 27, 2026
Merged

Allow group members to record settlements on behalf of the payer #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
97 changes: 52 additions & 45 deletions src/pages/GroupDetail.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -370,7 +370,7 @@ export default function GroupDetail() {
<span className="currency text-osps-red font-semibold">
{formatCurrency(t.amount, group.currency)}
</span>
{isOwnedByMe && !isConfirming && (
{!isConfirming && (
<button
onClick={() => {
setSettlingIndex(i)
Expand All @@ -386,51 +386,58 @@ export default function GroupDetail() {
</div>

{/* Confirm row: appears below when entering an amount */}
{isOwnedByMe && isConfirming && (
<div className="mt-3 pt-3 border-t border-osps-gray-light flex items-center gap-2 animate-fadeIn">
<div className="flex-1 relative">
<span className="absolute left-3 top-1/2 -translate-y-1/2 text-osps-gray text-sm pointer-events-none">
{group.currency}
</span>
<input
type="text"
inputMode="decimal"
autoFocus
value={settlingAmount}
onChange={(e) => {
// Permit digits and at most one decimal point.
const v = e.target.value.replace(/[^0-9.]/g, '')
const parts = v.split('.')
const sanitized = parts.length > 2
? parts[0] + '.' + parts.slice(1).join('')
: v
setSettlingAmount(sanitized)
}}
onKeyDown={(e) => {
if (e.key === 'Enter') recordSettlement(t, settlingAmount)
if (e.key === 'Escape') { setSettlingIndex(null); setSettlingAmount('') }
}}
placeholder={t.amount.toFixed(2)}
aria-label="Amount paid"
className="w-full pl-12 pr-3 py-2 text-[16px] font-mono rounded-lg
border border-osps-gray-light focus:border-osps-green focus:outline-none
focus:ring-2 focus:ring-osps-green/20 transition-all"
/>
{isConfirming && (
<div className="mt-3 pt-3 border-t border-osps-gray-light animate-fadeIn">
{!isOwnedByMe && (
<p className="text-xs text-osps-gray mb-2">
Recording payment on behalf of <span className="font-medium">{fromName}</span>
</p>
)}
<div className="flex items-center gap-2">
<div className="flex-1 relative">
<span className="absolute left-3 top-1/2 -translate-y-1/2 text-osps-gray text-sm pointer-events-none">
{group.currency}
</span>
<input
type="text"
inputMode="decimal"
autoFocus
value={settlingAmount}
onChange={(e) => {
// Permit digits and at most one decimal point.
const v = e.target.value.replace(/[^0-9.]/g, '')
const parts = v.split('.')
const sanitized = parts.length > 2
? parts[0] + '.' + parts.slice(1).join('')
: v
setSettlingAmount(sanitized)
}}
onKeyDown={(e) => {
if (e.key === 'Enter') recordSettlement(t, settlingAmount)
if (e.key === 'Escape') { setSettlingIndex(null); setSettlingAmount('') }
}}
placeholder={t.amount.toFixed(2)}
aria-label="Amount paid"
className="w-full pl-12 pr-3 py-2 text-[16px] font-mono rounded-lg
border border-osps-gray-light focus:border-osps-green focus:outline-none
focus:ring-2 focus:ring-osps-green/20 transition-all"
/>
</div>
<button
onClick={() => { setSettlingIndex(null); setSettlingAmount('') }}
className="text-xs font-display font-semibold text-osps-gray px-3 py-2 rounded-lg
hover:bg-osps-gray-light/50 active:scale-[0.97] transition-all"
>
Cancel
</button>
<button
onClick={() => recordSettlement(t, settlingAmount)}
className="text-xs font-display font-semibold bg-osps-green text-white px-3 py-2 rounded-lg
hover:bg-osps-green/90 active:scale-[0.97] transition-all"
>
Confirm
</button>
</div>
<button
onClick={() => { setSettlingIndex(null); setSettlingAmount('') }}
className="text-xs font-display font-semibold text-osps-gray px-3 py-2 rounded-lg
hover:bg-osps-gray-light/50 active:scale-[0.97] transition-all"
>
Cancel
</button>
<button
onClick={() => recordSettlement(t, settlingAmount)}
className="text-xs font-display font-semibold bg-osps-green text-white px-3 py-2 rounded-lg
hover:bg-osps-green/90 active:scale-[0.97] transition-all"
>
Confirm
</button>
</div>
)}
</div>
Expand Down
8 changes: 8 additions & 0 deletions supabase/migrations/allow_member_record_settlement.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
-- Allow any group member to record a settlement, not just the payer.
-- The payer (paid_by) is still whoever the transaction says — this just
-- removes the restriction that the recorder must be the payer.
drop policy "Members can create settlements" on public.settlements;

create policy "Members can create settlements"
on public.settlements for insert
with check (public.is_group_member(group_id));
Loading