SDK-6066 [Android][ND] Phase 11: Kotlin-first ND classes + factory named args

[CTLalit]

Part of epic SDK-6055 · ticket SDK-6066. Stacked on #1068. Kotlin-first cleanup of the ND fcap code (done on top of the stack, incremental).

Kotlin conversions (idiomatic, behavior-preserving)

• NdFCManager.java → NdFCManager.kt — @JvmStatic isFcapManaged (Java AnalyticsManager calls it), shownTodayCount as a val, when/runCatching/string-templates; renamed the private init(...) → initDailyState(...) to avoid clashing with the Kotlin init {} block.
• NdFcapGate.java → NdFcapGate.kt (internal object).
• DisplayUnitResponse.java → DisplayUnitResponse.kt (internal; nullable ND deps + content-only secondary constructor for the send-test/preview path).

Idiom fixes

• ControllerManager: import for NativeDisplayController instead of the fully-qualified name.
• CleverTapFactory: named arguments on every Kotlin constructor call.
• New Kotlin uses imports — no fully-qualified class names.

Named args — Java-constructor limitation

This module does not enable javaParameters, and Kotlin named arguments don't compile against Java constructors without it (every pre-existing named-arg call in the factory already targets a Kotlin class). So Java-defined constructors are intentionally left positional; named args were applied to all Kotlin constructions. Enabling javaParameters module-wide to cover the rest is a separate call.

Tests

• Added EvalRulesTest, HeaderVoteListsTest, NativeDisplayControllerTest.
• Extended EventQueueManagerTest to assert the ND-controller fan-out.
• All pass, incl. the unchanged NdFCManagerTest / NdFcapGateTest / DisplayUnitResponseTest (proving the conversions preserve behavior) + EvaluationManagerTest, QueueHeaderBuilderTest, InAppControllerTest.

Coverage matrix — every touched class

Class	Test
NdFCManager	NdFCManagerTest
NdFcapGate	NdFcapGateTest
DisplayUnitResponse	DisplayUnitResponseTest
NativeDisplayController	NativeDisplayControllerTest (new)
EvalRules	EvalRulesTest (new)
HeaderVoteLists	HeaderVoteListsTest (new)
NdStore	NdStoreTest
NdEvaluationManager	NdEvaluationManagerTest
EventQueueManager (ND fan-out)	EventQueueManagerTest (extended)
QueueHeaderBuilder (ndtlc/ndmp)	QueueHeaderBuilderTest
ControllerManager / CleverTapFactory (wiring)	exercised via CleverTapFactoryTest + the above

🤖 Generated with Claude Code

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)

• \b(master|main|develop)(_\w*)?

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 7888dfb9-7b65-4248-8091-3a404f48dcde

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[shubhambjadhavar]

✅ Snyk checks have passed. No issues have been found so far.

Status	Scan Engine	Critical	High	Medium	Low	Total (0)
✅	Open Source Security	0	0	0	0	0 issues
✅	Licenses	0	0	0	0	0 issues
✅	Code Security	0	0	0	0	0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

[clevertap-vision]

Code Review

Summary

Phase 11 converts NdFCManager, NdFcapGate and DisplayUnitResponse from Java to Kotlin, adds named arguments to the Kotlin constructions in CleverTapFactory, and adds EvalRulesTest / HeaderVoteListsTest / NativeDisplayControllerTest. I diffed each converted file line-by-line against its deleted Java original: control flow, cap ordering, catch scopes, pref key derivation and the parseDisplayUnits cache-write-once path are all faithfully preserved, all named arguments resolve against real Kotlin parameter names, and every remaining Java caller (AnalyticsManager, CleverTapAPI, LoginController, ControllerManager) still links because Kotlin internal is public in bytecode.

📊 Visual Overview

flowchart LR
  subgraph Converted["Java → Kotlin (this PR)"]
    A["NdFCManager.kt<br/>@JvmStatic isFcapManaged<br/>shownTodayCount val<br/>init → initDailyState"]
    B["NdFcapGate.kt<br/>internal object<br/>returns List"]
    C["DisplayUnitResponse.kt<br/>internal + content-only ctor"]
  end
  F["CleverTapFactory.kt<br/>named args"] --> A
  F --> C
  C --> B --> A
  JavaCallers["AnalyticsManager.java<br/>CleverTapAPI.java"] -.-> A
  JavaCallers -.-> C
  T["New tests:<br/>EvalRules · HeaderVoteLists<br/>NativeDisplayController"] -.-> Converted

Loading

Verdict

APPROVE

The conversions are behavior-preserving apart from one benign, self-healing capture-semantics change in NdFCManager's async init; the remaining notes are readability/doc hygiene.

---

Automatic reviews run once per commit — the same commit isn't re-reviewed. Push a new commit to trigger a fresh review.

Reviewed by Vision AI

[clevertap-vision]

💡 SUGGESTION — Bug: This is the one place the conversion is not behavior-preserving. In the deleted Java the async task captured the constructor parameter deviceId (an effectively-final local), so the deferred init(...) always ran for the device id the manager was built with. Here deviceId inside the lambda resolves to the mutable property this.deviceId and is read when the task actually executes — if changeUser(newId) (LoginController.java:177) lands before the queued task runs, initDailyState runs twice for the new id and the original user's daily-counter reset is skipped for that day.

Impact is low (counters are keyed per device id and the reset self-heals on the next changeUser back to that user), but it's an unintended delta in a PR advertised as behavior-preserving. Pin the value:

Suggested change

	initDailyState(deviceId)
	init {
	val initialDeviceId = deviceId
	executors.postAsyncSafelyTask<Unit>().execute("initNdFCManager") {
	initDailyState(initialDeviceId)
	}
	}

[clevertap-vision]

💡 SUGGESTION — Code quality: UNCAPPED is the right name for the tlc/tdc defaults on lines 40-41, but it's also used as the optInt default for efc and excludeGlobalFCaps (lines 35-36), which are presence/boolean flags — -1 there means "absent", not "uncapped". It also silently duplicates NdFCManager.UNCAPPED, which this PR made private, so the two can now drift. Either add a separate ABSENT = -1 for the flag lookups, or make NdFCManager.UNCAPPED internal and reuse it for the two cap defaults.

[clevertap-vision]

💡 SUGGESTION — Code quality: The epic's living design doc still points at the pre-conversion filenames — docs/NativeDisplayFrequencyCaps.md:52 and :420 reference response/DisplayUnitResponse.java, and :143 references NdFCManager.getNdCounts/init (now initDailyState). Worth updating in this PR since it's the file-map readers use to navigate the ND channel.