Benchmark PRs on machines chosen by machine:<ec2-type> labels#1010
Merged
Conversation
The PR benchmark always ran on c6a.4xlarge, but some systems cannot work there — e.g. Hyrise (#883), an in-memory DBMS whose encoded hits table alone exceeds the machine's 32 GB. The manual workflow can target any machine, but its runs are invisible on the PR until the results sink picks them up, and every re-run needs a manual dispatch. A maintainer can now add one or more `machine:<ec2-type>` labels to a PR (e.g. `machine:c6a.metal`) to override the default machine, one run per label. Adding such a label relaunches the benchmark immediately; other labels don't trigger anything. Labels can only be set by users with triage access, and every launch stays gated by the `benchmark-approval` environment, so the cost control is unchanged. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
`machine:all`, `machine:all-amd` and `machine:all-arm` labels expand to the machine sets of the daily runs (the lists mirror benchmark-daily.yml), deduplicated against explicitly labeled machines. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hitstable alone likely exceeds the machine's 32 GB.machine:<ec2-type>labels to a PR (e.g.machine:c6a.metal) to override the default machine — one run per machine. Adding such a label relaunches the benchmark immediately (thelabeledtrigger is filtered so other labels don't launch anything, and a state guard keeps closed PRs inert).machine:all,machine:all-amdandmachine:all-armexpand to the machine sets of the daily runs (mirroringbenchmark-daily.yml), deduplicated against explicitly labeled machines.pull_request_targetstill takes the workflow from the base branch, and every launch remains gated by thebenchmark-approvalenvironment.Test plan
all-arm,all,all-amd+all-arm,all+ explicit duplicate (deduplicated), two explicit machines, and no labels (falls back toc6a.4xlarge)machine:c6a.metalto Add Hyrise #883 and check that the launched run uses c6a.metal🤖 Generated with Claude Code