Introduce Bool Type#492
Open
IyeOnline wants to merge 2 commits intoClickHouse:masterfrom
Open
Conversation
Previously the library implicitly converted bool columns to `Uint8`, loosing type information. This commit introduces a "strong type" for `Bool` that is distinct from `bool`. This allows complete re-use of `ColumnVector` without triggering the `std::vector<bool>` specialization. This new type is guarded behind a CMake variable/preprocessor define `CH_MAP_BOOL_TO_UINT8`, which is enabled by default in order to keep compatibility for library users. In the future the default should be switched first and the variable then removed later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the library implicitly converted bool columns to
Uint8,loosing type information.
This commit introduces a "strong type" for
Boolthat is distinct frombool. This allows complete re-use ofColumnVectorwithout triggeringthe
std::vector<bool>specialization.This new type is guarded behind a CMake variable/preprocessor define
CH_MAP_BOOL_TO_UINT8, which is enabled by default in order to keepcompatibility for library users. In the future the default should be
switched first and the variable then removed later.