UX improvements - #35
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Critical redaction and schema-graph correctness issues, plus preview and documentation fixes, remain unresolved.
Review effort: Lite
Findings: 2
Open (5)
Skip all SQL lexical regions before detecting engine calls · New Match JSON keys instead of substrings during redaction · New Run and echo the schema graph preview test output · New Aggregate dictionaries across replicas in cloud mode · New Override main padding for sidebar visibility in print mode · New
What changed in this PR
This PR improves dashboard navigation and adds schema-graph collection, rendering, redaction, and related diagnostics.
Changes:
- Adds a responsive collapsible sidebar and updated dashboard header.
- Adds schema graph, refreshable-view, index, and metadata collectors.
- Adds SQL/JSONL redaction, cloud configuration handling, previews, tests, and documentation.
Review findings:
Makefile— moderate (3 votes): preview target omits the schema graph test and generated-file output.README.md— nit (1 vote): qualify schema graph availability when no readable user objects exist.internal/collection/sqlredact.go— critical (1 vote): raw substring matching can miss sensitive JSON fields.internal/collection/sqlredact.go— critical (1 vote): SQL scanning does not skip all quoted regions and comments.internal/dashboard/generator.go— nit (2 votes): print mode retains an unnecessary sidebar gutter.internal/dashboard/generator.go— moderate (1 vote): generated HTML contains duplicate doctypes.internal/dashboard/schema_graph.go— moderate (3 votes): cloud dictionary data is not aggregated across replicas.internal/dashboard/schema_graph.go— moderate (1 vote): system dictionaries are not filtered from the graph.
| File | Description |
|---|---|
skills/clickhouse-diagnostic/references/health-checks.md |
Documents refreshable-view health checks. |
skills/clickhouse-diagnostic/references/file-guide.md |
Documents new schema evidence. |
skills/clickhouse-diagnostic/references/bundle-layout.md |
Documents graph output and redaction changes. |
README.md |
Documents schema graph, UX, and collection behavior. |
queries.onprem/system.tables.sql |
Collects table metadata. |
queries.onprem/system.data_skipping_indices.sql |
Collects skip-index metadata. |
queries.onprem/system.columns.sql |
Collects column key flags. |
queries.onprem/26.6.1.0/system.tables.sql |
Adds materialized-view target metadata. |
queries.onprem/25.4.1.0/system.tables.sql |
Adds table metadata. |
queries.onprem/24.2.1.0/system.tables.sql |
Adds table metadata. |
queries.onprem/23.12.1.0/system.view_refreshes.sql |
Collects refreshable-view state. |
queries.gov/system.tables.sql |
Adds hashed schema relationships. |
queries.gov/system.data_skipping_indices.sql |
Adds redacted skip-index data. |
queries.gov/system.columns.sql |
Adds hashed column flags. |
queries.gov/26.6.1.0/system.tables.sql |
Adds hashed view-target metadata. |
queries.gov/24.2.1.0/system.tables.sql |
Adds hashed table relationships. |
queries.gov/23.12.1.0/system.view_refreshes.sql |
Adds redacted refresh state. |
queries.cloud/system.tables.sql |
Collects cloud table metadata. |
queries.cloud/system.data_skipping_indices.sql |
Collects cloud skip-index metadata. |
queries.cloud/system.columns.sql |
Collects cloud column flags. |
queries.cloud/26.6.1.0/system.tables.sql |
Adds cloud view-target metadata. |
queries.cloud/25.4.1.0/system.tables.sql |
Adds cloud table metadata. |
queries.cloud/24.2.1.0/system.tables.sql |
Adds cloud table metadata. |
queries.cloud/23.12.1.0/system.view_refreshes.sql |
Collects replica refresh state. |
Makefile |
Updates dashboard preview targets. |
internal/query/versioned_test.go |
Tests versioned refresh queries. |
internal/query/redact_hook_test.go |
Tests collector redaction hooks. |
internal/query/gov_leak_test.go |
Tests government-mode hashing. |
internal/query/executor.go |
Redacts collector results. |
internal/dashboard/theme_test.go |
Updates dashboard header tests. |
internal/dashboard/schema_graph.go |
Implements schema graph generation. |
internal/dashboard/schema_graph_test.go |
Tests graph rendering and behavior. |
internal/dashboard/nav_spy_test.go |
Tests sidebar navigation. |
internal/dashboard/keeper_preview_test.go |
Adds graph data to previews. |
internal/dashboard/generator.go |
Adds graph integration and sidebar UX. |
internal/dashboard/files_panel_test.go |
Excludes the graph from file listings. |
internal/collection/sqlredact.go |
Implements SQL and JSONL credential redaction. |
internal/collection/sqlredact_test.go |
Tests redaction behavior. |
internal/collection/heuristics.go |
Generalizes redaction tokens. |
cmd/main.go |
Adjusts cloud configuration collection. |
cmd/local_collector_test.go |
Tests cloud configuration behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…ebar visibility in print mode' Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Screen.Recording.2026-09-28.at.11.35.36.AM.mov
This PR builds upon
mainandcami/schema-dependency-graphand adds small changes to the UX of the Dashboard[cloud] Version: 26.6.2191.--topbar-hmeasurement and anchor offsets are unchanged; the sidebar hangs from the same measured header height.