fix(runner): reject NUL bytes in file paths - #46
Open
fallintoplace wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reject file names containing NUL bytes in
validateFilePath().Why
A request can currently include a name such as
result\0.csv. It passes the existing relative path, canonical path, and shape checks, but Node rejects it later when the runner calls the filesystem. That turns invalid user input into a late filesystem error. ReturningValidationErrorat the validation boundary keeps the failure predictable and avoids sending malformed paths deeper into the runner.This is a validation and error-handling fix. It does not change normal file names or the existing path traversal rules.
Tests
bun test api/src/validation.test.ts