Force-migrate fibers under ThreadSanitizer#82
Closed
mstetsyuk wants to merge 1 commit into
Closed
Conversation
mstetsyuk
force-pushed
the
migrate-fibers-under-TSan
branch
from
59860d6 to
bc538e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using STL synchronisation primitives like
std::mutexshould be thread-affine. If a user callsstd::mutex::lock, then yield, then resume, thenstd::mutex::unlock, it's a bug because the fiber could migrate to another thread. But in my experience, it's quite hard to hit that bug in CI. To make it much simpler, I suggest we always add the fiber to the global ready queue under TSan.