-
Notifications
You must be signed in to change notification settings - Fork 2
feat(mac): proxy config + quota window routing root-cause fix #58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -789,6 +789,10 @@ fn build_login_command(real_codex_path: &Path, runtime_codex_home: &Path) -> Com | |
| command.arg("login"); | ||
| command.current_dir(runtime_codex_home); | ||
| command.env("CODEX_HOME", runtime_codex_home); | ||
| // codex login 的 OAuth 浏览器流程本身由浏览器走系统代理,但 codex | ||
| // CLI 本地起 callback server / 走 token exchange 时也可能发请求, | ||
| // 注入代理 env 与 app-server 路径保持一致。 | ||
| crate::shared::proxy::apply_proxy_env(&mut command); | ||
|
Comment on lines
+792
to
+795
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
When a configured proxy is required to reach OpenAI, only the login command receives AGENTS.md reference: AGENTS.md:L5-L8 Useful? React with 👍 / 👎. |
||
| command | ||
| } | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The tracked
src-tauri/Cargo.lockwas not updated with this feature change and contains neither reqwest's optionaltokio-socksdependency nor a corresponding dependency edge. Builds that require the committed lockfile, such ascargo build --lockedor reproducible/offline packaging, therefore cannot resolve the newly enabled feature without modifying the checkout; regenerate and commit the lockfile with the manifest change.Useful? React with 👍 / 👎.