Repository navigation
fix(country): case-insensitive lookup, shared codes and CountryForNumber - #3
Merged
Merged
Conversation
Cod3ddy
added this pull request to stack #8
September 29, 2026 21:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NewNormalizerandGetCountryByA2now accept lower-case codes like"mw".Shared dialling codes (1, 7, 44, 61 and others) now map to their main country, taken from libphonenumber, instead of whichever country came last in the file.
GetCountryByCode("1")is now the US, not the US Minor Outlying Islands.Adds
CountryForNumber, which finds the country for a+number by trying the longest dialling code first, so+1 684…is American Samoa. A Canadian number still comes back as the US, because telling them apart needs area codes.