Add flexible solver strategies, solution modes and result normalization to Modello#21
Draft
Add flexible solver strategies, solution modes and result normalization to Modello#21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Modelloinstances to handle legacy, set-based and parametric solver outputs.solution_modeand asolution_selectorto pick a solution when multiple exist.Description
SolverStrategy,SolutionMode, andSolutionKindenums and aSolveResultdataclass to represent normalized solver outputs.Modello.__init__withsolver_strategy,solution_mode, andsolution_selectorparameters and replace inlinesolvelogic with a dedicated_solve_constraintsmethod._solve_constraintswhich supports the legacysolvebehavior and asetstrategy that useslinsolve/nonlinsolveand falls back to per-symbolsolvesetfor parametric results, and returnsSolveResultobjects.Testing
pytestincluding new teststest_solver_unique_solution,test_solver_multiple_solution_permissive_and_selector, andtest_solver_underdetermined_set_strategy, and all tests passed.test_no_constraintsandtest_multiple_inheritance_expr_conflictwere executed and continued to pass.Codex Task