Skip to content

ComboBox: Render the default open/close icon - #652

Open
nurullahturkoglu wants to merge 1 commit into
CodeBeamOrg:devfrom
nurullahturkoglu:fix/combobox-adornment-icon-609
Open

nurullahturkoglu wants to merge 1 commit into
CodeBeamOrg:devfrom
nurullahturkoglu:fix/combobox-adornment-icon-609

Conversation

@nurullahturkoglu

@nurullahturkoglu nurullahturkoglu commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #609

Since #577, MudInputExtended renders the end adornment only when HasAdornmentEnd is true. MudComboBox passed HasAdornmentEnd="@(AdornmentEnd != null)", so the default open/close icon was never rendered unless a custom AdornmentEnd was set. It now passes true, like MudSelectExtended, since the combobox always fills that slot with either the custom adornment or the default icon.

Added ComboBox_OpenCloseIconTest. It checks that the ArrowDropDown icon is rendered and changes to ArrowDropUp when the menu opens. It fails without the fix, and the rest of the tests pass.

I also checked the first example on the docs site (Blazor Server, Chrome). Without the change there is no icon. With it, the icon is back and flips when the menu opens.

Before:
codebeam-609-before

After:
codebeam-609-after

@codecov

codecov Bot commented Oct 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 67.30%. Comparing base (b1e5a3f) to head (a99baf8).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #652   +/-   ##
=======================================
  Coverage   67.30%   67.30%           
=======================================
  Files         117      117           
  Lines        8487     8487           
  Branches     1498     1498           
=======================================
  Hits         5712     5712           
+ Misses       2243     2242    -1     
- Partials      532      533    +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MudComboBox: Open/Close Icon is not being rendered.

1 participant