fix: report catalog embedding latency in milliseconds - #2
Open
ivanmilevtues wants to merge 2 commits into
Open
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-01a081b5-9435-7555-a03c-caf44e0d0dbf Co-authored-by: Ivan Milev <ivanmilevtues@gmail.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
CodeBoarding reviewStatus: 1 changed component See the full change in CodeBoarding. graph LR
n_Ordering_and_Catalog_Services["Ordering and Catalog Services"]
n_MAUI_Client_Application["MAUI Client Application"]
n_Basket_Webhooks_and_Service_Defaults["Basket, Webhooks, and Service Defaults"]
n_Identity_Service["Identity Service"]
n_Web_Applications_and_UI_Components["Web Applications and UI Components"]
n_Event_Bus_Messaging_Infrastructure["Event Bus Messaging Infrastructure"]
n_Storefront_UI_Scripts["Storefront UI Scripts"]
n_Chatbot_UI_Script["Chatbot UI Script"]
n_Ordering_and_Catalog_Services -- "configures authentication with" --> n_Basket_Webhooks_and_Service_Defaults
n_Ordering_and_Catalog_Services -- "persists events using" --> n_Event_Bus_Messaging_Infrastructure
n_MAUI_Client_Application -- "navigates to settings view in" --> n_Basket_Webhooks_and_Service_Defaults
n_Basket_Webhooks_and_Service_Defaults -- "inherits base view model from" --> n_MAUI_Client_Application
n_Web_Applications_and_UI_Components -- "reads configuration using" --> n_Basket_Webhooks_and_Service_Defaults
classDef added fill:#1f883d,stroke:#0b5d23,color:#ffffff;
classDef modified fill:#bf8700,stroke:#7d4e00,color:#ffffff;
classDef deleted fill:#cf222e,stroke:#82071e,color:#ffffff,stroke-dasharray:5 3;
class n_Ordering_and_Catalog_Services modified;
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small source change
Both CatalogAI trace messages named their structured field
ElapsedMillisecondsbut supplied seconds. UseTotalMillisecondsand the matchingmssuffix for single and batch embedding generation. Embedding behavior is unchanged.Review-only cold-start exercise
Requested by @ivanmilevtues to validate CodeBoarding/CodeBoarding-action#120 after merging the review-only workflow in #1.
.codeboardingbaseline.CodeBoarding/CodeBoarding-action@refs/pull/120/headand explicitly setsdepth_cap: 3.Validation
git diff --checkand a targeted source check pass: both structured millisecond fields now useTotalMillisecondsandms. Full .NET compilation is left to existing CI (the local orb has no dotnet executable).Leave this PR open for inspection; it is the live fallback-mechanism test.