Skip to content

fix: report catalog embedding latency in milliseconds - #2

Open
ivanmilevtues wants to merge 2 commits into
mainfrom
fix/catalog-embedding-log-units
Open

fix: report catalog embedding latency in milliseconds#2
ivanmilevtues wants to merge 2 commits into
mainfrom
fix/catalog-embedding-log-units

Conversation

@ivanmilevtues

@ivanmilevtues ivanmilevtues commented Sep 8, 2026

Copy link
Copy Markdown
Member

Small source change

Both CatalogAI trace messages named their structured field ElapsedMilliseconds but supplied seconds. Use TotalMilliseconds and the matching ms suffix for single and batch embedding generation. Embedding behavior is unchanged.

Review-only cold-start exercise

Requested by @ivanmilevtues to validate CodeBoarding/CodeBoarding-action#120 after merging the review-only workflow in #1.

  • Only a CodeBoarding review job is configured: no sync workflow, no committed .codeboarding baseline.
  • The workflow references CodeBoarding/CodeBoarding-action@refs/pull/120/head and explicitly sets depth_cap: 3.
  • Expected: resolve the merge base; find no reusable baseline for that commit; run full base analysis directly at depth 3; seed and incrementally analyze this PR head; publish reusable base/head artifacts and post the whole-PR architecture review.
  • This intentionally small implementation change exercises source fingerprint changes without introducing an artificial service. It need not produce a new architecture component.

Validation

git diff --check and a targeted source check pass: both structured millisecond fields now use TotalMilliseconds and ms. Full .NET compilation is left to existing CI (the local orb has no dotnet executable).

Leave this PR open for inspection; it is the live fallback-mechanism test.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 8, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-08T16:23:20.935390Z ecbf0bc PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Sep 8, 2026

Copy link
Copy Markdown

CodeBoarding review

Status: 1 changed component

See the full change in CodeBoarding.

graph LR
    n_Ordering_and_Catalog_Services["Ordering and Catalog Services"]
    n_MAUI_Client_Application["MAUI Client Application"]
    n_Basket_Webhooks_and_Service_Defaults["Basket, Webhooks, and Service Defaults"]
    n_Identity_Service["Identity Service"]
    n_Web_Applications_and_UI_Components["Web Applications and UI Components"]
    n_Event_Bus_Messaging_Infrastructure["Event Bus Messaging Infrastructure"]
    n_Storefront_UI_Scripts["Storefront UI Scripts"]
    n_Chatbot_UI_Script["Chatbot UI Script"]
    n_Ordering_and_Catalog_Services -- "configures authentication with" --> n_Basket_Webhooks_and_Service_Defaults
    n_Ordering_and_Catalog_Services -- "persists events using" --> n_Event_Bus_Messaging_Infrastructure
    n_MAUI_Client_Application -- "navigates to settings view in" --> n_Basket_Webhooks_and_Service_Defaults
    n_Basket_Webhooks_and_Service_Defaults -- "inherits base view model from" --> n_MAUI_Client_Application
    n_Web_Applications_and_UI_Components -- "reads configuration using" --> n_Basket_Webhooks_and_Service_Defaults
    classDef added fill:#1f883d,stroke:#0b5d23,color:#ffffff;
    classDef modified fill:#bf8700,stroke:#7d4e00,color:#ffffff;
    classDef deleted fill:#cf222e,stroke:#82071e,color:#ffffff,stroke-dasharray:5 3;
    class n_Ordering_and_Catalog_Services modified;
Loading

download artifacts · run 34255273794

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants