Skip to content

fix: add .zip extension and error handling to zip downloads #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
yuviiios wants to merge 1 commit into
base: staging
Choose a base branch
from
Open

fix: add .zip extension and error handling to zip downloads #524

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions src/context/filterContext.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,7 @@ export const FilterProvider: React.FC<FilterProviderProps> = ({
new Set(selectedPapers.map((paper) => paper._id)),
).map((id) => selectedPapers.find((paper) => paper._id === id)) as IPaper[];

let successCount = 0;
await Promise.all(
uniquePapers.map(async (paper) => {
try {
Expand All @@ -157,11 +158,17 @@ export const FilterProvider: React.FC<FilterProviderProps> = ({
const blob = await response.blob();
const filename = generateFileName(paper);
zip.file(filename, blob);
successCount++;
} catch (err) {
console.error(`Failed to fetch ${paper.file_url}`, err);
}
}),
);
);

if (successCount === 0) {
toast.error("Failed to download any papers. Please try again.");
return;
}

function getDownloadName(
params: ReadonlyURLSearchParams,
Expand All @@ -177,13 +184,13 @@ export const FilterProvider: React.FC<FilterProviderProps> = ({
const a = document.createElement("a");
a.href = url;

a.download = getDownloadName(searchParams, "subject");
a.download = `${getDownloadName(searchParams, "subject")}.zip`;

document.body.appendChild(a);
a.click();
a.remove();
URL.revokeObjectURL(url);
toast.success("Download Initiated");
toast.success(`Downloaded ${successCount} of ${uniquePapers.length} papers`);
}, [searchParams, selectedPapers]);

const handleApplyFilters = useCallback(
Expand Down