Skip to content

Fix verification and revocation issues (#1336, #1337, #1339) - #1412

Merged
mftee merged 2 commits into
CodeGirlsInc:mainfrom
Ummi-001:feature/ummi-001-fixes
Sep 25, 2026
Merged

mftee merged 2 commits into
CodeGirlsInc:mainfrom
Ummi-001:feature/ummi-001-fixes

Conversation

@Ummi-001

@Ummi-001 Ummi-001 commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

Summary

This PR addresses three issues related to document verification and revocation:

#1336: Submit endpoint doesn't verify the hash against the Stellar anchor

  • Modified in to verify the document hash exists on Stellar after anchoring before marking the verification as CONFIRMED
  • If verification fails, the record is marked as FAILED instead of CONFIRMED

#1337: Verify endpoint has no caching layer

  • Integrated into
  • Responses are now cached by document hash to avoid repeated Stellar network calls

#1339: Revoked and deleted documents look identical in responses

  • Added field to verify endpoint responses
  • Clients can now distinguish between:
    • Never submitted (documentStatus: null)
    • Submitted but not verified (documentStatus: PENDING/ANALYZING/FLAGGED)
    • Verified and active (documentStatus: VERIFIED)
    • Revoked (documentStatus: REJECTED)

Testing

  • All existing tests pass
  • Manual verification of caching behavior
  • Verified that failed anchoring creates FAILED verification record

Closes #1336
Closes #1337
Closes #1338
Closes #1339

…rding as submitted

Fix CodeGirlsInc#1337: Add caching layer to verify endpoint

Fix CodeGirlsInc#1339: Include document status in verify response to distinguish revoked from never-submitted

Closes CodeGirlsInc#1336
Closes CodeGirlsInc#1337
Closes CodeGirlsInc#1339
@vercel

vercel Bot commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

@Ummi-001 is attempting to deploy a commit to the Mftee's projects Team on Vercel.

A member of the Team first needs to authorize it.

@drips-wave

drips-wave Bot commented Sep 24, 2026

Copy link
Copy Markdown

@Ummi-001 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@mftee mftee left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed. Verifying the document hash against the Stellar anchor before marking a submission CONFIRMED (falling back to FAILED on mismatch) closes a real trust gap — previously the endpoint appears to have trusted the anchoring call succeeding without confirming the hash was actually recorded on-chain. Caching verify responses by document hash avoids redundant Stellar network calls for repeat lookups. Adding documentStatus to the verify response so clients can distinguish never-submitted / pending / verified / revoked is a meaningful API improvement — revoked and deleted previously looked identical to callers. Found and fixed one real issue: an unused DocumentStatus import in verification.controller.ts that was failing the repo's lint check specifically for this file (separate from the broader pre-existing lint debt across the codebase). Approving.

@mftee
mftee merged commit 2a7d130 into CodeGirlsInc:main Sep 25, 2026
0 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants